fix: swap j/k keybindings to match Vim conventions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1fdbc38047c1036a8783c99f64119890b1aed61e Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
@ThomasK33 must be a member of the Coder team on Vercel to deploy. Learn more about collaboration on Vercel and other options here. |
Change-Id: I3b4839ad380eeb6362da75009ddfe018af49d201 Signed-off-by: Thomas Kosiewski <tk@coder.com>
- pr-overview.tsx: Convert undefined to null for CommentBox body prop, and normalize requested_reviewers null to undefined for MergeSection - github.tsx: Replace octokit.paginate with octokit.request (paginate not available in @octokit/core), remove non-existent clearPending call - user-hover-card.tsx: Add type assertion for pronouns field (not in @octokit/openapi-types schema yet) Change-Id: Ib140d36609368c8920416c9c0627726c0efb4020 Signed-off-by: Thomas Kosiewski <tk@coder.com>
Change-Id: Ifebfd59cce5c6a07854adffa9e24f9ace8ca5214 Signed-off-by: Thomas Kosiewski <tk@coder.com>
Member
|
my linting was all wack so fixing this in main directly ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
jandkkeys were mapped inversely to standard Vim keybindings:jkFix
Swapped the function calls so that:
jcallsnavigateToNextUnviewedFile()(down/forward)kcallsnavigateToPrevUnviewedFile()(up/backward)This aligns with standard Vim keybindings where
jmoves down andkmoves up.