-
Notifications
You must be signed in to change notification settings - Fork 86
should override PORT #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IamTaoChen
wants to merge
17
commits into
coder:main
Choose a base branch
from
IamTaoChen:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93
−8
Open
should override PORT #606
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
50298c6
should override PORT
IamTaoChen ed54aa9
add -autokill
IamTaoChen d9807e0
rm autokill
IamTaoChen 1e78f97
use curl check again
IamTaoChen cf3fbed
add health_check_with_retries and check_port_owned_by_user
IamTaoChen 582adaa
fix %{http_code}
IamTaoChen 469f1cd
fix $PORT
IamTaoChen 6bc4558
fix check_port_owned_by_user
IamTaoChen e39a012
debug
IamTaoChen 484936a
test
IamTaoChen b88d30a
test
IamTaoChen 9561764
fix
IamTaoChen 97d3340
format warn and debug
IamTaoChen d59ed92
rewrite health_check_with_retries
IamTaoChen ec95aae
fix
IamTaoChen 24919cf
cleanup
IamTaoChen b26906f
Merge branch 'main' into main
IamTaoChen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -292,11 +292,11 @@ VNC_LOG="/tmp/kasmvncserver.log" | |||||||||||||||||||||||||||||||||||
| printf "🚀 Starting KasmVNC server...\n" | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| set +e | ||||||||||||||||||||||||||||||||||||
| kasmvncserver -select-de "${DESKTOP_ENVIRONMENT}" -disableBasicAuth > "$VNC_LOG" 2>&1 | ||||||||||||||||||||||||||||||||||||
| kasmvncserver -select-de "${DESKTOP_ENVIRONMENT}" -websocketPort "${PORT}" -disableBasicAuth > "$VNC_LOG" 2>&1 | ||||||||||||||||||||||||||||||||||||
| RETVAL=$? | ||||||||||||||||||||||||||||||||||||
| set -e | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| if [[ $RETVAL -ne 0 ]]; then | ||||||||||||||||||||||||||||||||||||
| if [[ $RETVAL -ne 0 ]] && ! curl -s http://127.0.0.1:"${PORT}"/app; then | ||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
| if [[ $RETVAL -ne 0 ]] && ! curl -s http://127.0.0.1:"${PORT}"/app; then | |
| # Retry health check up to 10 times with 1s delay | |
| health_check_with_retries() { | |
| local url=$1 | |
| local max_attempts=10 | |
| local attempt=1 | |
| while (( attempt <= max_attempts )); do | |
| if curl -s "$url" > /dev/null; then | |
| return 0 | |
| fi | |
| sleep 1 | |
| ((attempt++)) | |
| done | |
| return 1 | |
| } | |
| if [[ $RETVAL -ne 0 ]] && ! health_check_with_retries "http://127.0.0.1:${PORT}/app"; then |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The curl command is used without checking if it's available. The script already has a download_file function that handles multiple download tools (curl, wget, busybox) as fallbacks. If curl is not available on the system, this health check will fail even if the server started successfully. Consider using a similar fallback pattern or checking for curl availability before using it.