Block fork pull request workflow jobs#1
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Repository UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Disabled knowledge base sources:
WalkthroughAll four GitHub Actions workflows receive fork-safety guards. Job-level ChangesCI Workflow Fork Safety Gating
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/immediate-response.yml:
- Line 14: The conditional filter in the if expression uses the wrong actor
string "githubactions[bot]" and therefore fails to exclude the built-in Actions
bot; update the actor check in the if expression (the compound condition that
includes github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' &&
github.actor != 'githubactions[bot]' && github.actor != 'octokitbot') to use the
correct "github-actions[bot]" value so the built-in GitHub Actions bot is
properly excluded.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 77fac40a-f611-4382-9e34-3293e1a768c9
📒 Files selected for processing (4)
.github/workflows/add_to_octokit_project.yml.github/workflows/codeql.yml.github/workflows/immediate-response.yml.github/workflows/test.yml
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary
Why
Public fork pull requests can run attacker-controlled workflow code. Skipping those jobs prevents those pull requests from reaching repository secrets through GitHub Actions.
Validation
yq e '.'.Summary by CodeRabbit