SANDBOX-1889: update e2e wait helper default to PhoneLookupModeDisabled

[fbm3307]

Update UntilToolchainConfigHasPhoneLookupMode to treat nil as PhoneLookupModeDisabled instead of PhoneLookupModeLog.

Related Prs
API: codeready-toolchain/api#515
host-operator: codeready-toolchain/host-operator#1274

registration service: codeready-toolchain/registration-service#604

Assisted By : Cursor

Summary by CodeRabbit

• Bug Fixes
  • Updated phone lookup mode checks to treat an unset value as disabled by default.
  • Improved the reported differences when the current setting does not match the expected value.

[coderabbitai]

Walkthrough

The change updates a test-support helper function so that a nil PhoneLookupMode field defaults to PhoneLookupModeDisabled instead of PhoneLookupModeLog, affecting both the match comparison logic and the generated diff message.

Changes

Phone lookup mode default update

Layer / File(s)	Summary
Update default fallback mode testsupport/wait/host.go	Changes the fallback value for nil PhoneLookupMode from PhoneLookupModeLog to PhoneLookupModeDisabled in both Match logic and Diff output computation.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: test

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: the e2e wait helper now defaults nil phone lookup mode to PhoneLookupModeDisabled.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, metlos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,fbm3307,metlos]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fbm3307]

playwright download issue, in dashboard tests, normal e2e pass

[fbm3307]

/test e2e

[fbm3307]

/test e2e
fixed the playright dependecy error #1296

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud