Extend edit paddings view #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New input view for selecting one value from a small set of options using radio buttons. Useful for binary choices or small option sets where all choices should be visible at once. REDMINE-21191
Allow passing a values array to snap the slider to specific values instead of a continuous range. Optionally provide texts array to display custom labels for each value. REDMINE-21191
REDMINE-21191
REDMINE-21191
Rendering a slider with defaultValue but no model attribute would incorrectly save the default value to the model. The jQuery UI slider triggers slidechange when value is set programmatically during load, which called save(). Use a loading flag to skip saves during load. REDMINE-21191
REDMINE-21191
Allow controlling `exposeMotifArea` and introduce additional `portraitExposeMotifArea` and `customPortraitPaddings` which still need to be wired up in frontend layout. REDMINE-21191
The portrait padding settings are only relevant when a separate portrait backdrop image or video has been configured. Hide the tab for color backdrops entirely, as there's nothing portrait-specific to configure. REDMINE-21191
Display padding direction icons in section padding sliders to help users understand which slider controls top vs bottom padding. Extract inline SVGs from SectionPaddingsInputView into reusable SVG files. REDMINE-21191
REDMINE-21191
Ensures the section is visible in the preview before opening the paddings editor, improving user experience when editing sections that are off-screen. REDMINE-21191
Highlights the padding indicators in the preview when clicking the paddings button, providing visual feedback for which section is being edited. REDMINE-21191
Allow subclasses to specify which tab should be initially selected when the configuration editor is displayed. REDMINE-21191
Allow disabling smooth scrolling when navigating to sections via the SCROLL_TO_SECTION message. Useful when sections should appear immediately without animation. REDMINE-21191
When switching between landscape and portrait tabs in the paddings editor, the preview now stays scrolled to the section being edited instead of jumping to a different position. REDMINE-21191
When editing section paddings with a portrait backdrop, switching between landscape and portrait tabs now automatically toggles the preview emulation mode to show the appropriate viewport. REDMINE-21191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-21191