Skip to content

Conversation

@Rollocraft
Copy link
Contributor

This pull request includes several changes to language files, command registration, and various plugin classes to improve functionality and fix issues. The most important changes include adding new language settings, fixing attribute references, and introducing a new challenge.

Language File Updates:

  • Added new timer messages and language settings in language/files/de.json. [1] [2] [3]
  • Added corresponding updates in language/files/en.json. [1] [2] [3] [4]

Command Registration:

  • Registered a new LanguageCommand in plugin/src/main/java/net/codingarea/challenges/plugin/Challenges.java.

Attribute Reference Fixes:

  • Replaced Attribute.GENERIC_MAX_HEALTH with Attribute.MAX_HEALTH in multiple files to ensure compatibility with newer API versions:
    • plugin/src/main/java/net/codingarea/challenges/plugin/challenges/custom/settings/action/impl/HealEntityAction.java
    • plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/challenge/ZeroHeartsChallenge.java [1] [2]
    • plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/challenge/randomizer/RandomizedHPChallenge.java [1] [2] [3]
    • plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/goal/GetFullHealthGoal.java [1] [2]
    • plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/challenge/world/LoopChallenge.java

New Challenge Implementation:

  • Introduced a new DelayDamageChallenge class that accumulates player damage and applies it after a set period.

Biome Handling Updates:

  • Updated biome handling to use NamespacedKey and Registry for better compatibility and to avoid null pointer exceptions:
    • plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/challenge/force/ForceBiomeChallenge.java [1] [2] [3]
    • plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/goal/forcebattle/ForceBiomeBattleGoal.java [1] [2]

New Setting Implementation:

  • Added a new LanguageSetting class to allow players to change the language in the game settings.

@DomiIRL DomiIRL requested a review from Copilot April 10, 2025 19:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 27 out of 29 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • language/files/de.json: Language not supported
  • language/files/en.json: Language not supported

@DomiIRL DomiIRL changed the title Merge 10.04.2025 v2.3.3 Apr 10, 2025
@DomiIRL DomiIRL changed the title v2.3.3 Release v2.3.3 Apr 10, 2025
@DomiIRL DomiIRL requested a review from Copilot April 10, 2025 19:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 28 out of 30 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • language/files/de.json: Language not supported
  • language/files/en.json: Language not supported
Comments suppressed due to low confidence (1)

plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/setting/LanguageSetting.java:49

  • [nitpick] The TODO comment regarding the arrow symbol is unclear. Consider clarifying or removing this comment so that future maintainers understand if further action is needed.
//TODO: Wie macht man diesen Pfeil? → Prefix falsch!

@Rollocraft Rollocraft requested a review from Copilot April 11, 2025 06:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 29 out of 31 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • language/files/de.json: Language not supported
  • language/files/en.json: Language not supported

@Rollocraft Rollocraft marked this pull request as draft April 11, 2025 15:13
@EinfachBeez EinfachBeez self-assigned this Apr 12, 2025
@EinfachBeez EinfachBeez added size: medium type: release New version is released, merge into master status: unconfirmed labels Apr 12, 2025
@EinfachBeez EinfachBeez self-requested a review April 12, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: medium status: unconfirmed type: release New version is released, merge into master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants