-
Notifications
You must be signed in to change notification settings - Fork 18
Release v2.3.3 #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.3.3 #60
Conversation
…allenge' into development # Conflicts: # language/files/de.json # language/files/en.json # plugin/src/main/java/net/codingarea/challenges/plugin/management/challenges/ChallengeLoader.java # plugin/src/main/resources/plugin.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 27 out of 29 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- language/files/de.json: Language not supported
- language/files/en.json: Language not supported
plugin/src/main/java/net/codingarea/challenges/plugin/spigot/command/LanguageCommand.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 28 out of 30 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- language/files/de.json: Language not supported
- language/files/en.json: Language not supported
Comments suppressed due to low confidence (1)
plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/setting/LanguageSetting.java:49
- [nitpick] The TODO comment regarding the arrow symbol is unclear. Consider clarifying or removing this comment so that future maintainers understand if further action is needed.
//TODO: Wie macht man diesen Pfeil? → Prefix falsch!
...garea/challenges/plugin/challenges/implementation/challenge/damage/DelayDamageChallenge.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 29 out of 31 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- language/files/de.json: Language not supported
- language/files/en.json: Language not supported
This pull request includes several changes to language files, command registration, and various plugin classes to improve functionality and fix issues. The most important changes include adding new language settings, fixing attribute references, and introducing a new challenge.
Language File Updates:
language/files/de.json. [1] [2] [3]language/files/en.json. [1] [2] [3] [4]Command Registration:
LanguageCommandinplugin/src/main/java/net/codingarea/challenges/plugin/Challenges.java.Attribute Reference Fixes:
Attribute.GENERIC_MAX_HEALTHwithAttribute.MAX_HEALTHin multiple files to ensure compatibility with newer API versions:plugin/src/main/java/net/codingarea/challenges/plugin/challenges/custom/settings/action/impl/HealEntityAction.javaplugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/challenge/ZeroHeartsChallenge.java[1] [2]plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/challenge/randomizer/RandomizedHPChallenge.java[1] [2] [3]plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/goal/GetFullHealthGoal.java[1] [2]plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/challenge/world/LoopChallenge.javaNew Challenge Implementation:
DelayDamageChallengeclass that accumulates player damage and applies it after a set period.Biome Handling Updates:
NamespacedKeyandRegistryfor better compatibility and to avoid null pointer exceptions:plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/challenge/force/ForceBiomeChallenge.java[1] [2] [3]plugin/src/main/java/net/codingarea/challenges/plugin/challenges/implementation/goal/forcebattle/ForceBiomeBattleGoal.java[1] [2]New Setting Implementation:
LanguageSettingclass to allow players to change the language in the game settings.