fix(sponsorship): open sponsor links in a new tab#1307
fix(sponsorship): open sponsor links in a new tab#1307NiallJoeMaher merged 3 commits intocodu-code:developfrom
Conversation
|
@Renanhcorrea is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
|
Hello @Renanhcorrea, thanks for opening your first Pull Request. The maintainers will review this Pull Request and provide feedback as soon as possible. Keep up the great work! |
|
Caution Review failedThe pull request is closed. WalkthroughSponsor images on the sponsorship page were made clickable: each Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/(app)/sponsorship/page.tsx (1)
101-101: Standardize attribute order for consistency.The attributes are in a different order (
rel,href,target) compared to the other sponsor links which use (href,target,rel). While functionally equivalent, consistent ordering improves code maintainability.Apply this diff to match the attribute order used in other sponsor links:
- <Link rel="noopener noreferrer" href="https://www.wework.com/" target="_blank"> + <Link href="https://www.wework.com/" target="_blank" rel="noopener noreferrer">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json,!**/*.json
📒 Files selected for processing (1)
app/(app)/sponsorship/page.tsx(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
app/(app)/sponsorship/page.tsx (2)
components/ui-components/link.tsx (1)
Link(12-22)components/PromptService/PromptLink.tsx (2)
LinkProps(22-86)LinkProps(9-19)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
🔇 Additional comments (3)
app/(app)/sponsorship/page.tsx (3)
83-89: LGTM!The external link implementation is correct with proper security attributes and consistent formatting.
92-98: LGTM!The external link implementation is correct with proper security attributes and consistent formatting.
74-107: External sponsor links implemented correctly.All external sponsor links now consistently open in new tabs with proper security attributes (
target="_blank"andrel="noopener noreferrer"), which addresses the issue mentioned in #1297.Note: The NineDots sponsor link (lines 65-71) uses internal navigation (
/company/ninedots) and does not open in a new tab, which follows standard UX practices for internal links. If all sponsor links should behave identically regardless of destination, you may want to addtarget="_blank"to the NineDots link as well.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
✨ Codu Pull Request 💻
Fixes #1297
Pull Request details
Fixed inconsistent behavior on the /sponsorship page where only one sponsor link opened in a new tab.
Any Breaking changes
None
Associated Screenshots
None
[Optional] What gif best describes this PR or how it makes you feel
None