Conversation
|
The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).
|
Summary of ChangesHello @alec-w, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a foundational audit logging mechanism within the SDK. It introduces new Protobuf definitions for audit log structures and a dedicated service to manage them. The changes include all necessary auto-generated code for Go and TypeScript, along with the integration of the new audit client into the existing Go SDK, ensuring that audit functionalities are readily available for use and testing. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new audit logging feature. It adds protobuf definitions for Log and AuditService, along with the corresponding generated Go and TypeScript code. It also includes a Go client and a fake client for the new service, and integrates them into the existing clientsets. The changes are well-structured. I have one suggestion to enhance the filtering capabilities in the AuditService.
| string event_type = 1; | ||
| string entity_type = 2; | ||
| string entity_id = 3; | ||
| // TODO add time based filters |
There was a problem hiding this comment.
The Filter message is missing time-based filtering capabilities, which is a crucial feature for an audit log service. The TODO comment indicates this is planned. I suggest adding start_time and end_time fields to enable filtering logs by a time range. You'll also need to import google/protobuf/timestamp.proto if you add these fields.
google.protobuf.Timestamp start_time = 4;
google.protobuf.Timestamp end_time = 5;
0d299a6 to
239c5ba
Compare
239c5ba to
a2b8874
Compare
Pairs with: