Skip to content

fix: generate TypeScript files for google/api proto dependencies#180

Merged
mattbates merged 2 commits intomainfrom
mb/generate-ts-files-google-dep
Feb 23, 2026
Merged

fix: generate TypeScript files for google/api proto dependencies#180
mattbates merged 2 commits intomainfrom
mb/generate-ts-files-google-dep

Conversation

@mattbates
Copy link
Contributor

Add include_imports: true to the TypeScript buf plugin so that imported BSR dependencies (googleapis/googleapis) are also generated. This adds the missing gen/ts/google/api/field_behavior_pb.ts and resource_pb.ts files referenced by trust_zone_service and trust_provider proto files.

Add include_imports: true to the TypeScript buf plugin so that imported
BSR dependencies (googleapis/googleapis) are also generated. This adds
the missing gen/ts/google/api/field_behavior_pb.ts and resource_pb.ts
files referenced by trust_zone_service and trust_provider proto files.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the bug Something isn't working label Feb 21, 2026
@github-actions
Copy link

github-actions bot commented Feb 21, 2026

The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 21, 2026, 11:12 PM

@gemini-code-assist
Copy link

Summary of Changes

Hello @mattbates, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue in the TypeScript code generation process for Protobuf files. By enabling the include_imports option in the buf plugin configuration, the system now correctly generates TypeScript definitions for external Google API proto dependencies. This ensures that all necessary type definitions are available, preventing compilation errors and improving the overall robustness of the generated codebase.

Highlights

  • TypeScript Generation Fix: The TypeScript buf plugin has been configured to include imported dependencies, resolving an issue where certain Google API proto files were not being generated.
  • Dependency Resolution: Missing TypeScript files for google/api/field_behavior.proto and google/api/resource.proto have been generated, which were previously referenced by trust_zone_service and trust_provider proto files.
  • Buf Configuration Update: The buf.gen.yaml configuration was updated to add include_imports: true for the TypeScript generator, ensuring comprehensive code generation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • buf.gen.yaml
    • Added include_imports: true to the TypeScript generator options.
  • gen/ts/google/api/field_behavior_pb.ts
    • Generated new TypeScript file for google.api.FieldBehavior enum and its associated extension.
  • gen/ts/google/api/resource_pb.ts
    • Generated new TypeScript file for google.api.ResourceDescriptor and google.api.ResourceReference messages, along with their extensions and nested enums.
Activity
  • No human activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly addresses the issue of missing TypeScript definitions for Google API dependencies by enabling include_imports in the buf.gen.yaml configuration. This ensures that field_behavior.proto and resource.proto are generated and included in the SDK, which is necessary for resolving references in the service proto files. The generated code is consistent with the protoc-gen-es v2.2.3 plugin and the project's dependency on @bufbuild/protobuf. No issues were identified in the configuration or the resulting generated files.

@mattbates mattbates added this to the now milestone Feb 21, 2026
@mattbates mattbates merged commit 791b0b2 into main Feb 23, 2026
5 checks passed
@mattbates mattbates deleted the mb/generate-ts-files-google-dep branch February 23, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants