Unify temporary directory allocation strategy in tests#160
Merged
Conversation
cottsay
approved these changes
Jun 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 54.74% 54.74%
=======================================
Files 10 10
Lines 780 780
Branches 163 163
=======================================
Hits 427 427
Misses 307 307
Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the upstream unification in
colcon/colcon-core#729, this PR refactors the test suite to use the moderntmp_pathfixture (which provides apathlib.Pathobject) instead of mixing multiple temporary directory strategies.Specifically, this package previously mixed:
TemporaryDirectorymanagement (intest/test_package_identification_cmake.py,test/test_environment_cmake_prefix_path.py, andtest/test_environment_cmake_module_path.py)tmpdirfixture (intest/test_task_cmake_build.py)This refactor:
test/conftest.pycompatibility fixture fortmp_path(supporting older pytest versions, such as those on Enterprise Linux 8).tmp_pathfixture, removing the need for manual context managers or castings.test/spell_check.wordsto account for new spelling words introduced by the compatibility fixture (isdigit,itertools,linux,takewhile,tmpdir) and removes the now-unusedtempfile.test/test_flake8.pyto prevent line-length limits (E501) when adding common ignore lists.Reference
Specifics
Unlike some packages in the ecosystem which solely used
TemporaryDirectoryortmpdir,colcon-cmakehad a mix of both.🤖 Assisted by Gemini