Skip to content

driver_vive: downgrade unknown lightcap report from error to warning #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rocketmark wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

driver_vive: downgrade unknown lightcap report from error to warning #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/driver_vive.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3106,8 +3106,13 @@ void survive_data_cb_locked(uint64_t time_received_us, SurviveUSBInterface *si)
} else if (id == VIVE_REPORT_USB_TRACKER_LIGHTCAP_V1) {
SV_INFO("USB lightcap report is of an unexpected type for %s: %d (0x%02x)", obj->codename, id, id);
} else {
SV_ERROR(SURVIVE_ERROR_HARWARE_FAULT, "USB lightcap report is of an unknown type for %s: %d (0x%02x)",
obj->codename, id, id);
/* Unknown report IDs are emitted by newer tracker firmware that
* this version of libsurvive doesn't know about. Treating an
* unrecognised ID as a hardware fault is wrong — it crashes the
* process on firmware upgrades. Downgrade to a warning and ignore
* the packet so tracking continues on all known report types. */
SV_WARN("USB lightcap report is of an unknown type for %s: %d (0x%02x); ignoring",
obj->codename, id, id);
}

break;
Expand Down
Loading