[WIP] Add vscode for web support#4
Open
surajmandalcell wants to merge 2 commits into
Open
Conversation
surajmandalcell
commented
Sep 18, 2024
surajmandalcell
commented
- Make changes to package and tsconfig files to support web
- Used vscode.workspace.fs to read and write files instead of fs
Author
|
#3 Refer to this issue |
collinc777
requested changes
Sep 19, 2024
| "typescript": "^5.4.5" | ||
| } | ||
| } No newline at end of file | ||
| { |
Owner
There was a problem hiding this comment.
Can you make the diff for this file smaller please?
Author
There was a problem hiding this comment.
idk what the issue is but I cant get the diff to work properly here, I've copy pasted the files before and after here you can check it out https://www.diffchecker.com/cX1NvPtY/
surajmandalcell
force-pushed
the
vscode-for-web-support
branch
4 times, most recently
from
9f961d1 to
a395591
Compare
- Used vscode.workspace.fs to read and write files instead of fs - Fix line endings, this time for sure
surajmandalcell
force-pushed
the
vscode-for-web-support
branch
from
a395591 to
a69614e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.