Test proof-irrelevance and parameterised records systematically - #110
Open
mvr wants to merge 4 commits into
Open
Test proof-irrelevance and parameterised records systematically#110mvr wants to merge 4 commits into
mvr wants to merge 4 commits into
Conversation
It feels excessive, but many of the combinations will end up being
lowered differently.
* `dependent-function-*` tests `(a : A) -> B a`
* `dependent-function-argument-*` tests `(a : A) -> (b : B a) -> C a b`
* `family-argument-*` tests `(a : A) -> B a -> Set/Prop`
* `lookup-{argument,field}-projection-*` tests families indexed by the output of a function
* `lookup-composition-*` tests the same for two a composite of functions
* `lookup-proof-result-argument` is a special case (could be expanded to 8 cases)
* `param-record-*` tests records parameterised by various things
* `param-record-type-family-* tests records parameterised by a type family specifically
* `proof-record-* tests records that contain a proof field
* `prop-record-* tests records that themselves live in `Prop`
* `equality-record-* tests equality of records
* `param-alias-*` tests parameterised records and aliases
* `empty-prop-record-function` tests functions into a trivial proposition
* `record-nested` is a minimal nested record case
Remove subsumed `lookup-proof-result-argument` special case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the Set/Prop combinations will end up being lowered differently, so I think it's worth doing all possibilities just to be sure. For these families, the runtime test is exactly the same across all the variants: the point is that the user shouldn't see that the storage for the theories could be very different.
dependent-function-*tests(a : A) -> B adependent-function-argument-*tests(a : A) -> (b : B a) -> C a bfamily-argument-*tests(a : A) -> B a -> Set/Proplookup-{argument,field}-projection-*tests families indexed by the output of a functionlookup-composition-*tests the same for a composite of functionsSome other compiler pathways were still missing tests:
param-record-*tests records parameterised by various thingsparam-record-type-family-*tests records parameterised by a type family specificallyproof-record-*tests records that contain a proof fieldprop-record-*tests records that themselves live inPropequality-record-*tests equality of recordsparam-alias-*tests parameterised records and aliasesempty-prop-record-functiontests functions into a trivial propositionrecord-nestedis a minimal nested record case