Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the extension skeleton initialization workflow to better support PIE/Composer-style packaging and improves repository hygiene for generated extension artifacts.
Changes:
- Extend
pskel initto accept an optionalvendor_name, and (for PHP < 8.5) generate acomposer.jsonfor the new extension. - Add
ext/.gitignoreto avoid committing common build/autotools artifacts produced inside/ext. - Add
.gitattributesexport-ignore rules and update devcontainer configs to symlink the workspacepskel.shinto/usr/local/bin/pskel.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pskel.sh |
Parses optional vendor, invokes ext_skel.php accordingly, and generates composer.json for PHP < 8.5. |
ext/.gitkeep |
Normalizes the marker content for uninitialized ext/. |
ext/.gitignore |
Ignores common generated artifacts inside the extension working directory. |
.gitattributes |
Defines export-ignore rules for producing a cleaner git archive. |
.devcontainer/local/devcontainer.json |
Adds postCreateCommand to symlink pskel to the workspace script. |
.devcontainer/devcontainer.json |
Same as above for the Codespaces devcontainer definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ame compatibility Agent-Logs-Url: https://github.com/colopl/pskel/sessions/1230dd04-b11e-4a54-b6ac-adfcf24d673a Co-authored-by: zeriyoshi <10289597+zeriyoshi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.