Skip to content

feat: support pie#54

Merged
zeriyoshi merged 3 commits intomainfrom
support_pie
Apr 3, 2026
Merged

feat: support pie#54
zeriyoshi merged 3 commits intomainfrom
support_pie

Conversation

@zeriyoshi
Copy link
Copy Markdown
Contributor

@zeriyoshi zeriyoshi commented Apr 3, 2026

  • Reviewed feedback about Composer package name validation
  • Add lowercase conversion for EXT_NAME and EXT_VENDOR (e.g. "MyExt" → "myext")
  • Add character validation to reject invalid Composer package name characters (spaces, slashes, @, etc.)
  • Run code review and security checks

@zeriyoshi zeriyoshi self-assigned this Apr 3, 2026
Copilot AI review requested due to automatic review settings April 3, 2026 08:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the extension skeleton initialization workflow to better support PIE/Composer-style packaging and improves repository hygiene for generated extension artifacts.

Changes:

  • Extend pskel init to accept an optional vendor_name, and (for PHP < 8.5) generate a composer.json for the new extension.
  • Add ext/.gitignore to avoid committing common build/autotools artifacts produced inside /ext.
  • Add .gitattributes export-ignore rules and update devcontainer configs to symlink the workspace pskel.sh into /usr/local/bin/pskel.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pskel.sh Parses optional vendor, invokes ext_skel.php accordingly, and generates composer.json for PHP < 8.5.
ext/.gitkeep Normalizes the marker content for uninitialized ext/.
ext/.gitignore Ignores common generated artifacts inside the extension working directory.
.gitattributes Defines export-ignore rules for producing a cleaner git archive.
.devcontainer/local/devcontainer.json Adds postCreateCommand to symlink pskel to the workspace script.
.devcontainer/devcontainer.json Same as above for the Codespaces devcontainer definition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pskel.sh Outdated
Comment thread pskel.sh
Comment thread pskel.sh
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ame compatibility

Agent-Logs-Url: https://github.com/colopl/pskel/sessions/1230dd04-b11e-4a54-b6ac-adfcf24d673a

Co-authored-by: zeriyoshi <10289597+zeriyoshi@users.noreply.github.com>
@zeriyoshi zeriyoshi merged commit 00f03d3 into main Apr 3, 2026
139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants