Conversation
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: zeriyoshi <10289597+zeriyoshi@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Pskel skeleton/tooling to align with upstream PHP changes by switching licensing to BSD-3-Clause, refreshing the LLVM toolchain in the dev image, and adjusting the extension initialization flow to better support modern PHP/ext_skel setups.
Changes:
- Update licensing references and LICENSE contents to BSD-3-Clause.
- Update Debian-based container setup to use the LLVM 22 apt repository + packages.
- Enhance
pskel initargument parsing (optional vendor) and generate acomposer.jsonfor newer PHP versions; add devcontainer post-create symlink forpskel.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pskel.sh |
Updates init argument handling and composer.json generation for new skeletons. |
Dockerfile |
Switches LLVM installation to v22 using signed apt repo and updates alternatives. |
LICENSE |
Replaces PHP License 3.01 text with BSD-3-Clause text/copyright lines. |
README.md |
Updates displayed license identifier. |
README_ja.md |
Updates displayed license identifier. |
ext/.gitignore |
Adds ignore rules for build artifacts generated under /ext. |
ext/.gitkeep |
Normalizes content/format (keeps uninitialized marker). |
.gitattributes |
Adds export-ignore rules for archive exports. |
.devcontainer/devcontainer.json |
Adds workspace folder + post-create symlink for pskel. |
.devcontainer/local/devcontainer.json |
Adds post-create symlink for pskel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: zeriyoshi <10289597+zeriyoshi@users.noreply.github.com>
Contributor
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BSD-3-Clause(follow PHP license changes)composer.jsongenerationpskel.shto symlink