Skip to content

Conversation

@thiagohora
Copy link
Contributor

@thiagohora thiagohora commented Dec 2, 2025

Details

  • Replace custom navigateJsonPath() method with Jayway JSONPath library
  • Simplify extractNestedValue() to use JsonPath.read() with configuration
  • Add JSON_PATH_CONFIG with options for null handling and exception suppression
  • Remove ~115 lines of manual path parsing code
  • Maintains backward compatibility with existing path formats
  • All 110 AutomationRuleEvaluatorsResourceTest tests passing

Change checklist

  • User facing
  • Documentation update

Issues

  • Resolves #
  • OPIK-3211

Testing

NA

Documentation

NA

- Replace custom navigateJsonPath() method with Jayway JSONPath library
- Simplify extractNestedValue() to use JsonPath.read() with configuration
- Add JSON_PATH_CONFIG with options for null handling and exception suppression
- Remove ~115 lines of manual path parsing code
- Maintains backward compatibility with existing path formats
- All 110 AutomationRuleEvaluatorsResourceTest tests passing
@github-actions github-actions bot added java Pull requests that update Java code Backend labels Dec 2, 2025
@thiagohora thiagohora changed the title refactor: Replace manual JSON traversal with JSONPath library [OPIK-3211] [BE] Replace manual JSON traversal with JSONPath library Dec 2, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Dec 2, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Backend Tests Results

  354 files  ± 0    354 suites  ±0   54m 8s ⏱️ +10s
5 917 tests ± 0  5 910 ✅ ± 0  7 💤 ±0  0 ❌ ±0 
5 893 runs  +35  5 886 ✅ +35  7 💤 ±0  0 ❌ ±0 

Results for commit f34aa2d. ± Comparison against base commit c9a7ac1.

♻️ This comment has been updated with latest results.

…pan Python evaluator

- Fix constructor in AutomationRuleEvaluatorSpanUserDefinedMetricPython to match parent signature (filters before code)
- Change super.filters to super.getFilters() in both evaluator and update classes
- All 110 AutomationRuleEvaluatorsResourceTest tests passing
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

SDK E2E Tests Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f34aa2d.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added the tests Including test files, or tests related like configuration. label Dec 2, 2025
@github-actions github-actions bot removed the tests Including test files, or tests related like configuration. label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants