Skip to content

Infsys 9133 3 stavovy boolean pro parametry #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iki-cz merged 6 commits into from
Apr 17, 2026
Merged

Infsys 9133 3 stavovy boolean pro parametry #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
833020a
- three state boolean for some params
SimonZanta Apr 16, 2026
3cf7f11
unset variable
SimonZanta Apr 16, 2026
528dc3b
fix: correct test expectations for boolean params to use string 'true…
SimonZanta Apr 16, 2026
8865215
Enable empty string as a valid value
SimonZanta Apr 17, 2026
45badc7
Merge branch 'master' into INFSYS-9133-3-stavovy-boolean-pro-parametry
SimonZanta Apr 17, 2026
836c7ee
phpstan
SimonZanta Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions src/Entity/Payment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class Payment
/**
* Payment parameters.
*
* @var array<string, bool|int|string|Money|array<int, string>>
* @var array<string, bool|int|string|Money|array<int, string>|null>
*/
protected $params = [
'test' => false,
Expand Down Expand Up @@ -636,10 +636,21 @@ public function setUrlPendingRedirect(string $urlPending): self

public function getChargeUnregulatedCardFees(): ?bool
{
return $this->params['chargeUnregulatedCardFees'] ?? null;
if ($this->params['chargeUnregulatedCardFees'] === null || $this->params['chargeUnregulatedCardFees'] === '') {
return null;
}

// aby se mi vracelo true a false jako boolean
return filter_var($this->params['chargeUnregulatedCardFees'],FILTER_VALIDATE_BOOLEAN);
}

public function setChargeUnregulatedCardFees(bool $chargeUnregulatedCardFees): self
/**
* Explicitně umožňuje přidat přirážku za neregulovanou kartu na platby s Apple Pay a Google Pay. Případně pro přímé zakázání pro konkrétní platbu
*
* @param null|bool|string $chargeUnregulatedCardFees
* @return Payment
*/
public function setChargeUnregulatedCardFees($chargeUnregulatedCardFees): self
{
$this->setParam('chargeUnregulatedCardFees', $chargeUnregulatedCardFees);

Expand All @@ -652,13 +663,18 @@ public function setChargeUnregulatedCardFees(bool $chargeUnregulatedCardFees): s
*/
public function getEnableApplePayGooglePay(): ?bool
{
return $this->params['enableApplePayGooglePay'] ?? null;
if ($this->params['enableApplePayGooglePay'] === null || $this->params['enableApplePayGooglePay'] === '') {
return null;
}

// aby se mi vracelo true a false jako boolean
return filter_var($this->params['enableApplePayGooglePay'],FILTER_VALIDATE_BOOLEAN);
}

/**
* Explicitně umožňuje povolení Apple Pay a Google Pay na platbách s přirážkami za neregulovanou kartu. Případně pro přímé zakázání pro konkrétní platbu
*
* @param null|bool $enableApplePayGooglePay
* @param null|bool|string $enableApplePayGooglePay
* @return Payment
*/
// Použit komentář místo parametrového typu kvůli nekompatibilitě s null hodnotou.
Expand Down
88 changes: 88 additions & 0 deletions tests/Integration/Entity/Request/PaymentCreateRequestCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,94 @@ protected function getPaymentScenarios(){
'initRecurringId' => '',
],
],
'3 state bool empty str' => [
'payment' => (new Payment())
->setPrice(Money::ofInt(123))
->setEnableApplePayGooglePay('')
->setChargeUnregulatedCardFees('')
,
'result' => [
'test' => 'false',
'prepareOnly' => 'true',
'preauth' => 'false',
'verification' => 'false',
'embedded' => 'false',
'method' => '',
'initRecurring' => 'false',
'account' => '',
'name' => '',
'price' => 12300,
'dynamicExpiration' => 'false',
'country' => '',
'curr' => '',
'label' => '',
'refId' => '',
'email' => '',
'phone' => '',
'fullName' => '',
'billingAddrCity' => '',
'billingAddrStreet' => '',
'billingAddrPostalCode' => '',
'billingAddrCountry' => '',
'delivery' => '',
'homeDeliveryCity' => '',
'homeDeliveryStreet' => '',
'homeDeliveryPostalCode' => '',
'homeDeliveryCountry' => '',
'category' => '',
'lang' => '',
'expirationTime' => '',
'url_paid' => '',
'url_cancelled' => '',
'url_pending' => '',
'initRecurringId' => '',
],
],
'3 state bool true false' => [
'payment' => (new Payment())
->setPrice(Money::ofInt(123))
->setEnableApplePayGooglePay('true')
->setChargeUnregulatedCardFees('false')
,
'result' => [
'test' => 'false',
'prepareOnly' => 'true',
'preauth' => 'false',
'verification' => 'false',
'embedded' => 'false',
'method' => '',
'initRecurring' => 'false',
'account' => '',
'name' => '',
'price' => 12300,
'dynamicExpiration' => 'false',
'country' => '',
'curr' => '',
'label' => '',
'refId' => '',
'email' => '',
'phone' => '',
'fullName' => '',
'billingAddrCity' => '',
'billingAddrStreet' => '',
'billingAddrPostalCode' => '',
'billingAddrCountry' => '',
'delivery' => '',
'homeDeliveryCity' => '',
'homeDeliveryStreet' => '',
'homeDeliveryPostalCode' => '',
'homeDeliveryCountry' => '',
'category' => '',
'lang' => '',
'expirationTime' => '',
'url_paid' => '',
'url_cancelled' => '',
'url_pending' => '',
'initRecurringId' => '',
'chargeUnregulatedCardFees' => 'false',
'enableApplePayGooglePay' => 'true',
],
],
];
}
}
Loading