fix: Website Bugs & Misc Fixes#859
Merged
curlyfriesplease merged 11 commits intomasterfrom Apr 1, 2026
Merged
Conversation
curlyfriesplease
changed the title
curlyfriesplease
commented
Apr 1, 2026
Comment on lines
+170
to
+173
| margin-top: ${spacing('md')}; | ||
| margin-bottom: 0; | ||
| @media ${({ theme }) => theme.allBreakpoints('M')} { | ||
| margin: ${spacing('m')} 0 ${spacing('md')}; | ||
| margin-top: ${spacing('m')}; |
Contributor
Author
There was a problem hiding this comment.
Small correction to the way the moneybuy copy & submit button are spaced out from each other, now that the moneybuy copy can actually hide, it highlighted a design mismatch in that case
curlyfriesplease
changed the title
AndyEPhipps
approved these changes
Apr 1, 2026
Contributor
AndyEPhipps
left a comment
AndyEPhipps
left a comment
There was a problem hiding this comment.
Looks good to me, matey
|
🎉 This PR is included in version 8.68.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
In support of the latest multi-fix ticket for the website project ENG-4930, this makes the following small fixes and amendments:
ENG-4945:
Allows both banners to accept and use 'copyColor', a suitably contrasting black or white calculated by the frontend, to display the Text Only variants' title and subtitles.
ENG-4948
This copy seen here was previously a single size across all breakpoints. Now, in L+ breakpoint, it's slightly larger, as is its line height.
ENG-4943
Success copy now shows by itself, previously the TItle/Body copy (i.e. 'Stay in the know! Sign up etc etc...') was not set to disappear, and was showing above this success copy.
ENG-4987
Moneybuys were always showing, because the FE was passing
hideMoneyBuysbut the CL was expectingnoMoneyBuys. Also, the moneybuy copy wasn't set to hide.ENG-4949
Corrects the line height of moneybuy copy to 1.5rem
ENG-4953
Corrects the default background of the impact slider from
grey_extra_lighttogrey_lightWhy is this required?
Post-release corrections to the banners, as part of the website project.
link to Jira ticket:
ENG-4930
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...