Open
Conversation
adeebshihadeh
force-pushed
the
kthread-cpumask
branch
from
4371b33 to
d7f0b2a
Compare
geohot
reviewed
Jul 6, 2021
| @@ -319,6 +319,7 @@ struct task_struct *kthread_create_on_node(int (*threadfn)(void *data), | |||
| */ | |||
| sched_setscheduler_nocheck(task, SCHED_NORMAL, ¶m); | |||
| set_cpus_allowed_ptr(task, cpu_all_mask); | |||
Contributor
There was a problem hiding this comment.
Why are both of these lines still here? Isn't there one line where they can be scheduled anywhere?
geohot
reviewed
Jul 6, 2021
| @@ -488,6 +489,7 @@ int kthreadd(void *unused) | |||
| set_task_comm(tsk, "kthreadd"); | |||
| ignore_signals(tsk); | |||
| set_cpus_allowed_ptr(tsk, cpu_all_mask); | |||
geohot
reviewed
Jul 6, 2021
| init start on certain processors and also to | ||
| control where kmod and other user space threads | ||
| are being spawned. Allows to keep kernel threads | ||
| away from certain cores unless absoluteluy necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://lwn.net/Articles/565932/