Honda: CANFD long control#2569
Conversation
|
Reopening as this is testing well with the cruise fault workaround linked in the description. |
|
In separate AEB testing, found that radar hud was previously blocked by safety. Changed this PR to allow it through to properly displays that CMBS is off on the instrument cluster. No driving impact noticed in testdrive. |
|
This PR has had no activity for 60 days. It will be automatically closed in 7 days if there is no activity. |
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 154 segments for: HONDA_ACCORD, HONDA_CIVIC_BOSCH, HONDA_CIVIC_2022, HONDA_CRV_5G, HONDA_CRV_HYBRID, HONDA_HRV_3G, HONDA_INSIGHT, HONDA_E, HONDA_PILOT_4G, HONDA_CRV, HONDA_FIT, HONDA_FREED, HONDA_HRV, HONDA_ODYSSEY, HONDA_PILOT, HONDA_RIDGELINE, HONDA_CIVIC Show changes |
|
This PR has had no activity for 60 days. It will be automatically closed in 7 days if there is no activity. |
Adding long control for Honda CANFD models.
Based on PR2162, rebaseling to current opendbc codebase, with addition of safety code.
This PR had been in draft for months, due to the cruise faults set at a subsequent drive after long control was enabled.
I suspect the car is detecting the radar tester and throwing a fault at shutdown. I matched every control bit from a factory ACC log upon shutdown, except for the radar tester, and the next drive still faulted. All Honda Bosch models retain prior faults for the first few seconds of a subsequent drive, so I have not found any other way to stop next-drive faulting beyond PR3029.
There are sometimes split-second error messages appearing on the dashboard before clearing, but long control is gated behind alphalong on dev-only, so release drivers will not see this.
Recent drive from a canfd loaner: ad9840558640c31d/00000195--03d04b0d1c