Skip to content

Honda: CANFD long control#2569

Open
mvl-boston wants to merge 58 commits into
commaai:masterfrom
mvl-boston:canfd-long
Open

Honda: CANFD long control#2569
mvl-boston wants to merge 58 commits into
commaai:masterfrom
mvl-boston:canfd-long

Conversation

@mvl-boston
Copy link
Copy Markdown
Contributor

@mvl-boston mvl-boston commented Jul 26, 2025

Adding long control for Honda CANFD models.

Based on PR2162, rebaseling to current opendbc codebase, with addition of safety code.

This PR had been in draft for months, due to the cruise faults set at a subsequent drive after long control was enabled.

I suspect the car is detecting the radar tester and throwing a fault at shutdown. I matched every control bit from a factory ACC log upon shutdown, except for the radar tester, and the next drive still faulted. All Honda Bosch models retain prior faults for the first few seconds of a subsequent drive, so I have not found any other way to stop next-drive faulting beyond PR3029.

There are sometimes split-second error messages appearing on the dashboard before clearing, but long control is gated behind alphalong on dev-only, so release drivers will not see this.

Recent drive from a canfd loaner: ad9840558640c31d/00000195--03d04b0d1c

@mvl-boston
Copy link
Copy Markdown
Contributor Author

Reopening as this is testing well with the cruise fault workaround linked in the description.

@mvl-boston mvl-boston marked this pull request as ready for review January 9, 2026 01:26
@github-actions github-actions Bot added DBC signals can related to CAN tools, aka opendbc/can/ labels Jan 9, 2026
@mvl-boston mvl-boston marked this pull request as draft January 9, 2026 06:21
@github-actions github-actions Bot removed can related to CAN tools, aka opendbc/can/ DBC signals labels Jan 9, 2026
@mvl-boston mvl-boston marked this pull request as ready for review January 9, 2026 06:36
@mvl-boston
Copy link
Copy Markdown
Contributor Author

In separate AEB testing, found that radar hud was previously blocked by safety. Changed this PR to allow it through to properly displays that CMBS is off on the instrument cluster. No driving impact noticed in testdrive.

@github-actions
Copy link
Copy Markdown
Contributor

This PR has had no activity for 60 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions Bot added the stale label Mar 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 11, 2026

Car behavior report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

Testing 154 segments for: HONDA_ACCORD, HONDA_CIVIC_BOSCH, HONDA_CIVIC_2022, HONDA_CRV_5G, HONDA_CRV_HYBRID, HONDA_HRV_3G, HONDA_INSIGHT, HONDA_E, HONDA_PILOT_4G, HONDA_CRV, HONDA_FIT, HONDA_FREED, HONDA_HRV, HONDA_ODYSSEY, HONDA_PILOT, HONDA_RIDGELINE, HONDA_CIVIC

⚠️ 2 changed, 152 passed, 0 errors

Show changes

HONDA_PILOT_4G - 9662a1dab70c9dc3/00000000--f8bf47be5d/0

  carParams.alphaLongitudinalAvailable (1 diffs)

<!-- thollander/actions-comment-pull-request "car_diff" -->

@github-actions github-actions Bot removed the stale label Mar 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR has had no activity for 60 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions Bot added the stale label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car safety vehicle-specific safety code car related to opendbc/car/ honda stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants