Skip to content

setup: simplify cache branch#37630

Merged
sshane merged 10 commits intomasterfrom
atomic-setup-installer
Mar 10, 2026
Merged

setup: simplify cache branch#37630
sshane merged 10 commits intomasterfrom
atomic-setup-installer

Conversation

@sshane
Copy link
Contributor

@sshane sshane commented Mar 10, 2026

cached installed broken since #35960, silently wasn't running installer to fetch and checkout

on mici before commaai/flash#191, flash.comma.ai was flashing a custom mici userdata with cache that likely had openpilot properly on release-mici (ccf7361)

then we do a fcopyfile in setup which isn't atomic, and comma.sh may not run the installer:

log from comma.sh

running installer                                                                                               
/usr/comma/comma.sh: line 101: /tmp/installer: Text file busy

then it continues to run continue.sh written from setup: https://github.com/commaai/agnos-builder/blob/6655610bc9d95aa42f169c27cae5a4520aedcf05/userspace/usr/comma/comma.sh#L78-L80


now after that flash PR, we flash userdata on release-tizi (built from https://github.com/commaai/agnos-builder/blob/master/scripts/build_userdata.sh), installer never runs to check out proper branch, and it breaks the install

and on tici, it sometimes silently doesn't fetch using cache

@sshane sshane marked this pull request as draft March 10, 2026 02:56
@github-actions github-actions bot added the ui label Mar 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

UI Preview

mici: Videos are identical! View Diff Report
big: Videos are identical! View Diff Report

@sshane sshane changed the title setup: atomically place installer setup: simplify cache branch Mar 10, 2026
@sshane
Copy link
Contributor Author

sshane commented Mar 10, 2026

I kept it in this bad state on release-tizi, then downloaded the release installer from azure, then touched /data/.openpilot_cache and ran the installer, and it used cached fetch and checked out release-mici and comma.sh launched openpilot properly.

@sshane sshane marked this pull request as ready for review March 10, 2026 05:25
@sshane sshane merged commit bd5fbba into master Mar 10, 2026
10 of 11 checks passed
@sshane sshane deleted the atomic-setup-installer branch March 10, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant