Conversation
Contributor
UI Previewmici: Videos are identical! View Diff Report |
Contributor
Author
|
I kept it in this bad state on |
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cached installed broken since #35960, silently wasn't running installer to fetch and checkout
on mici before commaai/flash#191, flash.comma.ai was flashing a custom mici userdata with cache that likely had openpilot properly on release-mici (ccf7361)
then we do a
fcopyfilein setup which isn't atomic, and comma.sh may not run the installer:log from comma.sh
then it continues to run continue.sh written from setup: https://github.com/commaai/agnos-builder/blob/6655610bc9d95aa42f169c27cae5a4520aedcf05/userspace/usr/comma/comma.sh#L78-L80
now after that flash PR, we flash userdata on release-tizi (built from https://github.com/commaai/agnos-builder/blob/master/scripts/build_userdata.sh), installer never runs to check out proper branch, and it breaks the install
and on tici, it sometimes silently doesn't fetch using cache