Skip to content

Nissan: fix steering wheel offset in some cases#38116

Merged
sshane merged 1 commit into
masterfrom
fix-nissan-lat-offset
May 31, 2026
Merged

Nissan: fix steering wheel offset in some cases#38116
sshane merged 1 commit into
masterfrom
fix-nissan-lat-offset

Conversation

@sshane
Copy link
Copy Markdown
Collaborator

@sshane sshane commented May 31, 2026

commaai/opendbc#3423

Would have caused the car to have weird offsetting in the lane, as we were calculating a steering wheel offset from an angle the EPS didn't control against. This one is also much more precise

@sshane sshane changed the title Nissan: Nissan: fix steering offset in some cases May 31, 2026
@github-actions github-actions Bot added the car vehicle-specific label May 31, 2026
@sshane sshane changed the title Nissan: fix steering offset in some cases Nissan: fix steering wheel offset in some cases May 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

⚠️ 1 changed, 65 passed, 0 errors

Show changes

NISSAN - regen15D60604EAB|2025-04-08--23-06-59--0 [card]

  carState.steeringAngleDeg (5999 diffs)
    frame 1: 3.9000000953674316 -> 5.079999923706055
    frame 2: 3.799999952316284 -> 5.0
    frame 3: 3.799999952316284 -> 4.929999828338623
    frame 4: 3.799999952316284 -> 4.900000095367432
    frame 5: 3.799999952316284 -> 4.880000114440918
    frame 6: 3.700000047683716 -> 4.840000152587891
    frame 7: 3.700000047683716 -> 4.800000190734863
    frame 8: 3.5999999046325684 -> 4.760000228881836
    frame 9: 3.5999999046325684 -> 4.71999979019165
    frame 10: 3.5999999046325684 -> 4.670000076293945
    (... 5989 more)

@sshane sshane merged commit bc2b0d8 into master May 31, 2026
13 of 14 checks passed
@sshane sshane deleted the fix-nissan-lat-offset branch May 31, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car vehicle-specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant