Conversation
|
Thank you for the PR! If i'm not mistaken, this looks like mostly a duplicate of the work done in #525. probably the best approach would be for me to merge that PR in to main, and then you can apply your changes over the top of that |
The original reply below is no longer relevant, this has diverged a fair bit from the original of just updating the xcode project files.
|
|
@Airyzz I've made some additional changes and now commet is fully functional on MacOS. I connected to my matrix homeserver and started using it :) I'm still happy to build off the other PR if necessary |
|
@Airyzz this now successfully builds for iOS too |
|
And the Emoji display on iOS and MacOS is now fixed, as well as some other permission/sandbox/entitlements related problems. |
|
I made test builds for MacOS and iOS here: ios: https://mega.nz/file/5k5HGDhb#RosZgXD-unwdw5Sozvlqvz7pPAxHjPcmIFYu5XAyv-M |
Can confirm, building and running the macOS version using this PR works, emojis menu seems to function fine but I can't type any text. This is fully functional on your build/machine(s)? |
Oh, that's a strange one. I tested on macOS 26 and iOS 26. I sent messages in a Matrix space in a part of to share this particular build and to test it. What's the details of the system you are running it on? Did you use the prebuilt app or did you build yourself? I'm away from my Mac right now but I could share the exact build command I used for it if it is helpful. |
I have build it myself. I ran the command from the readme. should be this^ Apple Sillicon, should be macOS 26.4.1 for that device. |
|
Hi, thanks again for all your work on this!! I've merged #525 in to main! if you wouldn't mind, could you apply your fixes on top of this, and split this big PR in to a series of smaller PRs, it would be much easier for me to review and (hopefully) merge |
That should be Ok. Did you run the code gen step? It may also be worth trying to run |
Will do. I probably can't break down the xcode stuff to much, but I can definitely split it into iOS/macOS and the other code changes for emoji and the exception |
|
@Airyzz Done :)
I just realized though that maybe the PR 3 and 4 should be done first - because the build will fail due to the dependency issues (vodozemac + mediakit). But it doesn't build at the moment anyway so I don't think it's a major issue. |
I just checked on my Macbook, these were the build steps I used, I didn't include the both:
then iOS:
macOS:
or using flutter run iOS: macos: |
THIS PR IS NOW SUPERSEDED BY:
I have access to an MacOS computer (and iPads), so I thought I could have a stab at getting the build working. I've been working a lot with dart and flutter for my research platform, and have had to deal with some similar issues (with the exception of rust libs, I've been using C FFI native libs).I'm looking for some feedback on this PR, both in terms of scope and how you would like to have it chunked.
What this PR does:
important: While using the
maingithub version of the applemedia_kit_*packages fixes the main problem that broke the build, obviously pointing to the head of a repo is dangerous. Would you prefer:any is fine for me, once I know I can update the PR.
Thanks!
Test builds
ios: https://mega.nz/file/5k5HGDhb#RosZgXD-unwdw5Sozvlqvz7pPAxHjPcmIFYu5XAyv-M (will need to be sideloaded, it's an iOS .app)
macos: https://mega.nz/file/EkQiXByb#PhF6KuGEsG3r1ILT8TL_pwKzQXaqDsdXHnTJWwl1tfY
Edit: I wanted to make it clear that none of the changes in the PR, nor the text above used generative AI.