You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split EntryType::Regular into LegacyRegular and Regular.
Use b'0' instead of b'\0' by default in new_gnu and new_ustar.
In the wild (see grep.app) I see many uses of checks like if header.entry_type() != tar::EntryType::Regular. The first change would silently break such code, i.e. no compile error, but runtime behavior would change. Can it be designed in a non-breaking way?
The second change is less drastic, but still I'd prefer not to change the output across tar-rs versions within 0.4.x version range.
I suppose we could make EntryType::Regular into a tuple or struct variant with some information about if it's a 'legacy' regular file or not? That would break any code matching against EntryType::Regular so it doesn't silently fail.
Yeah, this PR basically has to be breaking because of the change in the encoded default entry type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breaking-change-wishlistBreaking changes that could be including in the next SemVer-incompatible release.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for #422
This is a breaking change to the library.