Conversation
Contributor
Storage Benchmark Results10MB Files
View full run · SVGs available as build artifacts |
Contributor
Sandbox Benchmark ResultsSequential
Staggered
Burst
View full run · SVGs available as build artifacts |
Contributor
Browser Benchmark Results
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a new browser benchmark mode that measures a full remote browser session lifecycle (create → CDP connect → navigate → release), integrates it into the main benchmark runner (--mode browser), and adds CI automation to run and comment benchmark results on PRs.
Changes:
- Added a new
src/browser/*benchmark module (types, runner, scoring, providers). - Integrated browser mode into
src/run.tsandsrc/merge-results.ts(including score computation + merged result output). - Added a PR workflow to run browser benchmarks and post a results table comment.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| src/storage/providers.ts | Minor comment tweak in provider list. |
| src/run.ts | Adds --mode browser execution path, provider filtering, and JSON output to results/browser/. |
| src/merge-results.ts | Adds browser-mode merge + table output + writes merged results/browser/latest.json. |
| src/browser/types.ts | Defines browser benchmark config/result/timing/stats types. |
| src/browser/scoring.ts | Adds composite scoring and sorting for browser benchmark results. |
| src/browser/providers.ts | Adds browser provider registry (currently empty). |
| src/browser/benchmark.ts | Implements sequential browser benchmark loop, timing, and JSON writer. |
| package.json | Adds browser bench scripts + dependencies (@computesdk/browserbase, playwright-core), changes @computesdk/blaxel version range. |
| package-lock.json | Locks added/updated dependencies for browser benchmarking. |
| .github/workflows/browser-benchmarks.yml | New workflow to run browser benchmarks on PRs and comment results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/browser/benchmark module that tests the full browser session lifecycle: create → CDP connect → navigate → release--mode browser) with provider filtering supportbrowserbaseas the first browser providerNew files
src/browser/types.ts— types for browser benchmark configs, timings, and resultssrc/browser/providers.ts— browser provider configurations (starting with Browserbase)src/browser/benchmark.ts— sequential benchmark runner with per-phase timingsrc/browser/scoring.ts— composite scoring weighted by total/create latency and success rate.github/workflows/browser-benchmarks.yml— CI workflow for PR checksUsage