fix: show "--" instead of "0.00s" for time metrics when all iterations fail#68
Merged
fix: show "--" instead of "0.00s" for time metrics when all iterations fail#68
Conversation
Contributor
Storage Benchmark Results10MB Files
View full run · SVGs available as build artifacts |
Contributor
Sandbox Benchmark ResultsSequential
Staggered
Burst
View full run · SVGs available as build artifacts |
There was a problem hiding this comment.
Pull request overview
Updates benchmark result renderers to avoid displaying misleading 0.00s timing values when a provider has 0 successful iterations, showing -- instead.
Changes:
- README HTML table: render
--for Median/P95/P99 TTI whenok === 0. - Sandbox SVG: render
--for Median/P95/P99 and force “slow” coloring whenok === 0. - Storage SVG: render
--for Download/Throughput/Upload and force “slow” coloring whenok === 0. - Sandbox CLI table: render
--for Median/P95/P99 columns whensuccessful === 0.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/update-readme.ts | Replaces TTI timing cells with -- when all iterations fail in README table output. |
| src/storage/generate-svg.ts | Shows -- for storage metrics and adjusts speed class when all iterations fail in generated SVG. |
| src/sandbox/table.ts | Prints -- for TTI timing columns when all iterations fail in the console table. |
| src/sandbox/generate-svg.ts | Shows -- for TTI metrics and adjusts speed class when all iterations fail in generated SVG. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.