Skip to content
This repository was archived by the owner on Feb 19, 2024. It is now read-only.

Use ensure_packages rather than forcing the installation of the dependency#30

Merged
ice799 merged 2 commits intocomputology:masterfrom
ColinHebert:ensure_package
Mar 8, 2017
Merged

Use ensure_packages rather than forcing the installation of the dependency#30
ice799 merged 2 commits intocomputology:masterfrom
ColinHebert:ensure_package

Conversation

@ColinHebert
Copy link
Contributor

ensure_packages is the recommended way to install packages within modules. It avoids conflicts with other modules that might require the same packages.

This is an updated version of #18

@ice799
Copy link
Contributor

ice799 commented Feb 16, 2017

What version of puppet includes ensure_packages? This module has to support many different versions of Puppet.

@ColinHebert
Copy link
Contributor Author

ColinHebert commented Feb 16, 2017

ensure_packages is a feature of the puppet stdlib module.
https://github.com/puppetlabs/puppetlabs-stdlib#ensure_packages

ensure_packages has been added to the stdlib (3.2.0) in 2012: https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/CHANGELOG.md#2012-09-18---chad-metcalf-chadwibidatacom---320

@ice799
Copy link
Contributor

ice799 commented Feb 16, 2017

OK. Sounds like this module may need a dependency on some minimum version of stdlib, which includes ensure_packages.

@ColinHebert
Copy link
Contributor Author

Fair point, I've bumped the stdlib version to a minimum of 3.2.0

@ice799
Copy link
Contributor

ice799 commented Mar 8, 2017

Just tested this and looks good. I noticed that the stdlib docs mention that stdlib 3.x supports puppet 2.7 and higher (if I am reading it correctly) which should be fine: https://forge.puppet.com/puppetlabs/stdlib/3.2.1.

Going to merge this -- thanks @ColinHebert for your work on this!

@ice799 ice799 merged commit 54ae944 into computology:master Mar 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants