Revert "Sanitize ~ in pathname (we do not use/rely on ~ ATM)"#216
Merged
yarikoptic merged 1 commit intomasterfrom Sep 2, 2025
Merged
Revert "Sanitize ~ in pathname (we do not use/rely on ~ ATM)"#216yarikoptic merged 1 commit intomasterfrom
yarikoptic merged 1 commit intomasterfrom
Conversation
This reverts commit 1609da8. It was not the reason and `~` is a legit character so I do not see the need to change behavior ATM. Continuing on - #215 - bids-standard/bids-validator#248
yarikoptic
added
patch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 61.24% 65.22% +3.97%
==========================================
Files 10 10
Lines 1383 1383
Branches 211 211
==========================================
+ Hits 847 902 +55
+ Misses 462 402 -60
- Partials 74 79 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1609da8.
It was not the reason and
~is a legit character so I do not see the need to change behavior ATM.Continuing on
will release right away so we do not exist with changed behavior for too long