Mark jupyter_client=6.2.0 as broken#256
Merged
Merged
Conversation
Member
|
Is it not supposed to break the API? |
SylvainCorlay
approved these changes
Apr 12, 2021
Member
This should have been a major release. |
7f7982f to
ed4def2
Compare
Member
(if the API has to be broken) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for marking packages as broken:
instead of marking packages as broken. This alternative workflow makes environments more reproducible.
not technically broken and should not be marked as such.
but should be patched in the repo data and be marked unbroken later.
the maintainers only, we can allow packages to be marked broken more liberally.
conda-forge/core) try to make a decision on these requests within 24 hours.Checklist:
broken/*for adding thebrokenlabel,not_broken/*for removing thebrokenlabel, ortoken_reset/*for token resets)
The
blockkwarg was removed fromget_msg(), which is breaking the API. See e.g. ipython/ipykernel#633.cc @SylvainCorlay