build-dm-verity-task: make the labels a parameter to the task#174
Open
littlejawa wants to merge 1 commit intoconfidential-devhub:mainfrom
Open
build-dm-verity-task: make the labels a parameter to the task#174littlejawa wants to merge 1 commit intoconfidential-devhub:mainfrom
littlejawa wants to merge 1 commit intoconfidential-devhub:mainfrom
Conversation
Collaborator
Author
|
/cc @snir911 @dbkreling This should help in the general case (making a new release should not involve modifying the build task). Keeping it as a draft for now, I want to double-check the resulting image. |
littlejawa
force-pushed
the
make_labels_a_parameter_to_the_task
branch
3 times, most recently
from
ecfb010 to
5d6a96f
Compare
Collaborator
Author
|
/retest |
The task currently has hardcoded labels that it applies to the image. Part of them contain the release version in it, forcing us to modify/rebuild the task every time we make a new release. It also means that a given task cannot be used for different releases. This commit moves the list of labels to a parameter to the task, and modify the build script to loop on that list and apply them one by one. It also modifies the dm-verity build pipelines to provide this list as intended. Similar changes are applied to the debug flavor of the build task and pipelines, for consistency. Signed-off-by: Julien Ropé <jrope@redhat.com>
littlejawa
force-pushed
the
make_labels_a_parameter_to_the_task
branch
from
bf37a29 to
f670966
Compare
Collaborator
Author
|
Verified using the "debug" image generated with this PR (the "normal" version is still using the previous build task). |
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task currently has hardcoded labels that it applies to the image. Part of them contain the release version in it, forcing us to modify/rebuild the task every time we make a new release. It also means that a given task cannot be used for different releases.
This commit moves the list of labels to a parameter to the task, and modify the build script to loop on that list and apply them one by one. It also modifies the dm-verity build pipelines to provide this list as intended.
Similar changes are applied to the debug flavor of the build task and pipelines, for consistency.