Fix coverage for conformance subprocesses#106
Merged
anuraaga merged 2 commits intoconnectrpc:mainfrom Jan 29, 2026
Merged
Conversation
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
stefanvanburen
approved these changes
Jan 28, 2026
Member
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
not in love with the hack in the first place (not sure how valuable coverage is with the conformance tests?), but fine to land this to at least fix what we had!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I randomly noticed coverage dropped a lot since conformance tests stopped being measured since pytest-cov 7.0, which removed "hacky" enabling for subprocesses
https://pypi.org/project/pytest-cov/
Unfortunately the replacement only patches python subprocess type of invocations and not Go runner processes - the hacky enabling was actually perfect for our use case.
I considered just downgrading, but I found it was easy enough to bring the embedded loader in from 6.3 and use it, we don't need automatic application since we control the code to just import it ourselves.