Switch generator to use bufbuild/protoplugin#119
Open
stefanvanburen wants to merge 2 commits intomainfrom
Open
Switch generator to use bufbuild/protoplugin#119stefanvanburen wants to merge 2 commits intomainfrom
stefanvanburen wants to merge 2 commits intomainfrom
Conversation
No strong feeling on landing this, but just wanted to see how our plugin would look if we integrated https://github.com/bufbuild/protoplugin, which eliminates some of the boilerplate of handling the plugin. Vaguely relates to #18, although I think the language the plugin is written in now is less important than ever. Also takes a pass at cleaning up the go code and tests. Signed-off-by: Stefan VanBuren <svanburen@buf.build>
stefanvanburen
commented
Feb 6, 2026
|
|
||
| resp.SupportedFeatures = proto.Uint64(uint64(pluginpb.CodeGeneratorResponse_FEATURE_PROTO3_OPTIONAL) | uint64(pluginpb.CodeGeneratorResponse_FEATURE_SUPPORTS_EDITIONS)) | ||
| resp.MinimumEdition = proto.Int32(int32(descriptorpb.Edition_EDITION_PROTO3)) | ||
| resp.MaximumEdition = proto.Int32(int32(descriptorpb.Edition_EDITION_2023)) |
Member
Author
There was a problem hiding this comment.
regardless of whether or not we land this, it's probably only a matter of time before we're asked to support edition 2024. (similar: grpc/grpc#40639)
Collaborator
There was a problem hiding this comment.
Cool - I don't mind adding that in this PR, or can be a different one, there doesn't seem to be any new syntax for services as usual
Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Member
Author
|
I know we've already solved our go -> wheel setup with goreleaser, but looks like https://github.com/simonw/go-to-wheel is a new approach (just wanted to mention!). |
anuraaga
approved these changes
Feb 7, 2026
|
|
||
| resp.SupportedFeatures = proto.Uint64(uint64(pluginpb.CodeGeneratorResponse_FEATURE_PROTO3_OPTIONAL) | uint64(pluginpb.CodeGeneratorResponse_FEATURE_SUPPORTS_EDITIONS)) | ||
| resp.MinimumEdition = proto.Int32(int32(descriptorpb.Edition_EDITION_PROTO3)) | ||
| resp.MaximumEdition = proto.Int32(int32(descriptorpb.Edition_EDITION_2023)) |
Collaborator
There was a problem hiding this comment.
Cool - I don't mind adding that in this PR, or can be a different one, there doesn't seem to be any new syntax for services as usual
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No strong feeling on landing this, but just wanted to see how our plugin would look if we integrated https://github.com/bufbuild/protoplugin, which eliminates some of the boilerplate of handling the plugin.
Vaguely relates to #18, although I think the language the plugin is written in now is less important than ever.
Also takes a pass at cleaning up the go code and tests.