Skip to content

ArtifactTypes fix #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VISTALL merged 2 commits into from
Apr 21, 2025
Merged

ArtifactTypes fix #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e633eb
Reformatting java-compiler-artifact-impl.
unv-unv Apr 21, 2025
ebfbb39
Fixing compilation of ArtifactTypes. Some refactoring.
unv-unv Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions ...artifact-impl/src/main/java/com/intellij/java/compiler/artifact/impl/ManifestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,30 +16,28 @@
package com.intellij.java.compiler.artifact.impl;

import consulo.application.Application;
import org.jetbrains.annotations.NonNls;

import java.util.jar.Attributes;

public class ManifestBuilder {
@NonNls
private static final String NAME = "Created-By";
private static final Attributes.Name CREATED_BY = new Attributes.Name(NAME);
private static final String NAME = "Created-By";
private static final Attributes.Name CREATED_BY = new Attributes.Name(NAME);

private ManifestBuilder() {
}
private ManifestBuilder() {
}

public static void setGlobalAttributes(Attributes mainAttributes) {
setVersionAttribute(mainAttributes);
setIfNone(mainAttributes, CREATED_BY, Application.get().getName().get());
}
public static void setGlobalAttributes(Attributes mainAttributes) {
setVersionAttribute(mainAttributes);
setIfNone(mainAttributes, CREATED_BY, Application.get().getName().get());
}

public static void setVersionAttribute(Attributes mainAttributes) {
setIfNone(mainAttributes, Attributes.Name.MANIFEST_VERSION, "1.0");
}
public static void setVersionAttribute(Attributes mainAttributes) {
setIfNone(mainAttributes, Attributes.Name.MANIFEST_VERSION, "1.0");
}

private static void setIfNone(Attributes mainAttributes, Attributes.Name attrName, String value) {
if (mainAttributes.getValue(attrName) == null) {
mainAttributes.put(attrName, value);
private static void setIfNone(Attributes mainAttributes, Attributes.Name attrName, String value) {
if (mainAttributes.getValue(attrName) == null) {
mainAttributes.put(attrName, value);
}
}
}
}
Loading
Loading