Skip to content

EP_NAME general refactoring (part 1) #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VISTALL merged 2 commits into from
May 2, 2025
Merged

EP_NAME general refactoring (part 1) #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6895054
Reformatting users of EP_NAME.
unv-unv May 1, 2025
fdac223
General refactoring of users of EP_NAME (part 1).
unv-unv May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...src/main/java/com/intellij/java/analysis/codeInspection/UnusedDeclarationFixProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,8 @@
*/
@ExtensionAPI(ComponentScope.APPLICATION)
public interface UnusedDeclarationFixProvider {
ExtensionPointName<UnusedDeclarationFixProvider> EP_NAME = ExtensionPointName.create(UnusedDeclarationFixProvider.class);

ExtensionPointName<UnusedDeclarationFixProvider> EP_NAME = ExtensionPointName.create(UnusedDeclarationFixProvider.class);

@Nonnull
IntentionAction[] getQuickFixes(PsiElement unusedElement);
@Nonnull
IntentionAction[] getQuickFixes(PsiElement unusedElement);
}
10 changes: 5 additions & 5 deletions ...-analysis-api/src/main/java/consulo/java/analysis/codeInspection/JavaExtensionPoints.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@
*/
@Deprecated
public interface JavaExtensionPoints {
@Nonnull
@Deprecated
ExtensionPointName<EntryPoint> DEAD_CODE_EP_NAME = ExtensionPointName.create(EntryPoint.class);
@Nonnull
@Deprecated
ExtensionPointName<EntryPoint> DEAD_CODE_EP_NAME = ExtensionPointName.create(EntryPoint.class);

@Nonnull
ExtensionPointName<CantBeStaticCondition> CANT_BE_STATIC_EP_NAME = ExtensionPointName.create(CantBeStaticCondition.class);
@Nonnull
ExtensionPointName<CantBeStaticCondition> CANT_BE_STATIC_EP_NAME = ExtensionPointName.create(CantBeStaticCondition.class);
}
575 changes: 294 additions & 281 deletions ...c/main/java/com/intellij/java/analysis/impl/codeInsight/daemon/impl/UnusedSymbolUtil.java
View file
Open in desktop

Large diffs are not rendered by default.

7,028 changes: 3,677 additions & 3,351 deletions .../java/com/intellij/java/analysis/impl/codeInsight/daemon/impl/analysis/HighlightUtil.java
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 6 additions & 7 deletions .../intellij/java/analysis/impl/codeInsight/quickfix/ChangeVariableTypeQuickFixProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

/*
* User: anna
* Date: 27-Aug-2009
*/
package com.intellij.java.analysis.impl.codeInsight.quickfix;

import consulo.annotation.component.ComponentScope;
Expand All @@ -27,9 +22,13 @@
import com.intellij.java.language.psi.PsiType;
import com.intellij.java.language.psi.PsiVariable;

/**
* User: anna
* Date: 27-Aug-2009
*/
@ExtensionAPI(ComponentScope.APPLICATION)
public interface ChangeVariableTypeQuickFixProvider {
ExtensionPointName<ChangeVariableTypeQuickFixProvider> EP_NAME = ExtensionPointName.create(ChangeVariableTypeQuickFixProvider.class);
ExtensionPointName<ChangeVariableTypeQuickFixProvider> EP_NAME = ExtensionPointName.create(ChangeVariableTypeQuickFixProvider.class);

IntentionAction[] getFixes(PsiVariable variable, PsiType toReturn);
IntentionAction[] getFixes(PsiVariable variable, PsiType toReturn);
}
16 changes: 9 additions & 7 deletions ...ain/java/com/intellij/java/analysis/impl/codeInspection/canBeFinal/CanBeFinalHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,16 @@
*/
@ExtensionAPI(ComponentScope.APPLICATION)
public abstract class CanBeFinalHandler {
public static final ExtensionPointName<CanBeFinalHandler> EP_NAME = ExtensionPointName.create(CanBeFinalHandler.class);
public static final ExtensionPointName<CanBeFinalHandler> EP_NAME = ExtensionPointName.create(CanBeFinalHandler.class);

public abstract boolean canBeFinal(PsiMember member);
public abstract boolean canBeFinal(PsiMember member);

public static boolean allowToBeFinal(PsiMember member) {
for (CanBeFinalHandler handler : EP_NAME.getExtensionList()) {
if (!handler.canBeFinal(member)) return false;
public static boolean allowToBeFinal(PsiMember member) {
for (CanBeFinalHandler handler : EP_NAME.getExtensionList()) {
if (!handler.canBeFinal(member)) {
return false;
}
}
return true;
}
return true;
}
}
63 changes: 35 additions & 28 deletions ...iler-impl/src/main/java/com/intellij/java/compiler/impl/javaCompiler/BackendCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,36 +28,43 @@

import jakarta.annotation.Nonnull;
import jakarta.annotation.Nullable;

import java.io.IOException;

@ExtensionAPI(ComponentScope.PROJECT)
public interface BackendCompiler {
ExtensionPointName<BackendCompiler> EP_NAME = ExtensionPointName.create(BackendCompiler.class);

@Nonnull
String getPresentableName();

@Nullable
default OutputParser createErrorParser(BackendCompilerProcessBuilder processBuilder, @Nonnull String outputDir, ProcessHandler process) {
return null;
}

@Nullable
default OutputParser createOutputParser(BackendCompilerProcessBuilder processBuilder, @Nonnull String outputDir) {
return null;
}

@Nullable
default BackendCompilerMonitor createMonitor(BackendCompilerProcessBuilder processBuilder) {
return null;
}

default boolean checkCompiler(final CompileScope scope) {
return true;
}

@Nonnull
BackendCompilerProcessBuilder prepareProcess(@Nonnull ModuleChunk chunk,
@Nonnull String outputDir,
@Nonnull CompileContext compileContext) throws IOException;
ExtensionPointName<BackendCompiler> EP_NAME = ExtensionPointName.create(BackendCompiler.class);

@Nonnull
String getPresentableName();

@Nullable
default OutputParser createErrorParser(
BackendCompilerProcessBuilder processBuilder,
@Nonnull String outputDir,
ProcessHandler process
) {
return null;
}

@Nullable
default OutputParser createOutputParser(BackendCompilerProcessBuilder processBuilder, @Nonnull String outputDir) {
return null;
}

@Nullable
default BackendCompilerMonitor createMonitor(BackendCompilerProcessBuilder processBuilder) {
return null;
}

default boolean checkCompiler(final CompileScope scope) {
return true;
}

@Nonnull
BackendCompilerProcessBuilder prepareProcess(
@Nonnull ModuleChunk chunk,
@Nonnull String outputDir,
@Nonnull CompileContext compileContext
) throws IOException;
}
Loading
Loading