Skip to content

Refactoring and localizing users of EP_NAME (part 8) #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VISTALL merged 3 commits into from
May 4, 2025
Merged

Refactoring and localizing users of EP_NAME (part 8) #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f824d17
Reformatting ModifierFix, RefCountHolder, QuickFixFactory and QuickFi…
unv-unv May 4, 2025
dc32be8
Refactoring and localizing users of EP_NAME (part 8).
unv-unv May 4, 2025
774b074
Refactoring and localizing users of EP_NAME (part 9).
unv-unv May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
686 changes: 405 additions & 281 deletions ...s-api/src/main/java/com/intellij/java/analysis/codeInsight/intention/QuickFixFactory.java
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 8 additions & 14 deletions ...m/intellij/java/analysis/impl/codeInsight/daemon/impl/analysis/GenericsHighlightUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ public static HighlightInfo checkElementInTypeParameterExtendsList(
return HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR)
.range(element)
.descriptionAndTooltip(JavaErrorLocalize.interfaceExpected())
.registerFix(QuickFixFactory.getInstance().createMoveBoundClassToFrontFix(aClass, type), null, null, null, null)
.registerFix(QuickFixFactory.getInstance().createMoveBoundClassToFrontFix(aClass, type))
.create();
}
else if (referenceElements.length != 0 && element != referenceElements[0]
Expand All @@ -408,7 +408,7 @@ else if (referenceElements.length != 0 && element != referenceElements[0]
return HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR)
.range(element)
.descriptionAndTooltip(JavaErrorLocalize.typeParameterCannotBeFollowedByOtherBounds())
.registerFix(QuickFixFactory.getInstance().createExtendsListFix(aClass, type, false), null, null, null, null)
.registerFix(QuickFixFactory.getInstance().createExtendsListFix(aClass, type, false))
.create();
}
return null;
Expand Down Expand Up @@ -598,7 +598,7 @@ public static HighlightInfo checkUnrelatedDefaultMethods(@Nonnull PsiClass aClas
return HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR)
.range(classIdentifier)
.descriptionAndTooltip(message)
.registerFix(QuickFixFactory.getInstance().createImplementMethodsFix(aClass), null, null, null, null)
.registerFix(QuickFixFactory.getInstance().createImplementMethodsFix(aClass))
.create();
}
if (isInterface || abstracts == null || unrelatedMethodContainingClass.isInterface()) {
Expand All @@ -623,7 +623,7 @@ public static HighlightInfo checkUnrelatedDefaultMethods(@Nonnull PsiClass aClas
return HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR)
.range(classIdentifier)
.descriptionAndTooltip(description)
.registerFix(QuickFixFactory.getInstance().createImplementMethodsFix(aClass), null, null, null, null)
.registerFix(QuickFixFactory.getInstance().createImplementMethodsFix(aClass))
.create();
}
}
Expand Down Expand Up @@ -992,7 +992,7 @@ public static HighlightInfo checkForeachExpressionTypeIsIterable(PsiExpression e
return HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR)
.range(expression)
.descriptionAndTooltip(JavaErrorLocalize.foreachNotApplicable(JavaHighlightUtil.formatType(expression.getType())))
.registerFix(QuickFixFactory.getInstance().createNotIterableForEachLoopFix(expression), null, null, null, null)
.registerFix(QuickFixFactory.getInstance().createNotIterableForEachLoopFix(expression))
.create();
}
return null;
Expand Down Expand Up @@ -1293,13 +1293,7 @@ public static HighlightInfo checkOverrideAnnotation(
return HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR)
.range(overrideAnnotation)
.descriptionAndTooltip(JavaErrorBundle.message("override.not.allowed.in.interfaces"))
.registerFix(
QuickFixFactory.getInstance().createIncreaseLanguageLevelFix(LanguageLevel.JDK_1_6),
null,
null,
null,
null
)
.registerFix(QuickFixFactory.getInstance().createIncreaseLanguageLevelFix(LanguageLevel.JDK_1_6))
.create();
}
return null;
Expand Down Expand Up @@ -1424,7 +1418,7 @@ public static HighlightInfo checkVarArgParameterIsLast(@Nonnull PsiParameter par
return HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR)
.range(parameter)
.descriptionAndTooltip(JavaErrorLocalize.varargNotLastParameter())
.registerFix(QuickFixFactory.getInstance().createMakeVarargParameterLastFix(parameter), null, null, null, null)
.registerFix(QuickFixFactory.getInstance().createMakeVarargParameterLastFix(parameter))
.create();
}
}
Expand Down Expand Up @@ -1581,7 +1575,7 @@ public static HighlightInfo checkGenericCannotExtendException(PsiReferenceList l
return HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR)
.range(referenceElement)
.descriptionAndTooltip(JavaErrorLocalize.genericExtendException())
.registerFix(QuickFixFactory.getInstance().createExtendsListFix(aClass, classType, false), null, null, null, null)
.registerFix(QuickFixFactory.getInstance().createExtendsListFix(aClass, classType, false))
.create();
}
}
Expand Down
Loading
Loading