Skip to content

Localizing inspections (part 7) #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VISTALL merged 1 commit into from
Oct 11, 2025
Merged

Localizing inspections (part 7) #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
612 changes: 321 additions & 291 deletions plugin/src/main/java/com/intellij/java/impl/codeInspection/RedundantSuppressInspection.java
View file
Open in desktop

Large diffs are not rendered by default.

84 changes: 41 additions & 43 deletions ...j/java/impl/codeInspection/concurrencyAnnotations/NonFinalFieldInImmutableInspection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,54 +26,52 @@
import consulo.language.editor.inspection.ProblemsHolder;
import consulo.language.editor.inspection.localize.InspectionLocalize;
import consulo.language.psi.PsiElementVisitor;
import org.jetbrains.annotations.Nls;

import consulo.localize.LocalizeValue;
import jakarta.annotation.Nonnull;

@ExtensionImpl
public class NonFinalFieldInImmutableInspection extends BaseJavaLocalInspectionTool {
@Nonnull
@Override
public LocalizeValue getGroupDisplayName() {
return InspectionLocalize.groupNamesConcurrencyAnnotationIssues();
}

@Override
@Nonnull
public String getGroupDisplayName() {
return InspectionLocalize.groupNamesConcurrencyAnnotationIssues().get();
}

@Override
@Nls
@Nonnull
public String getDisplayName() {
return "Non-final field in @Immutable class";
}

@Override
@Nonnull
public String getShortName() {
return "NonFinalFieldInImmutable";
}
@Nonnull
@Override
public LocalizeValue getDisplayName() {
return LocalizeValue.localizeTODO("Non-final field in @Immutable class");
}

@Override
@Nonnull
public String getShortName() {
return "NonFinalFieldInImmutable";
}

@Override
@Nonnull
public PsiElementVisitor buildVisitorImpl(@Nonnull final ProblemsHolder holder,
boolean isOnTheFly,
LocalInspectionToolSession session,
Object state) {
return new JavaElementVisitor() {
@Override
public void visitField(PsiField field) {
super.visitField(field);
if (field.hasModifierProperty(PsiModifier.FINAL)) {
return;
}
final PsiClass containingClass = field.getContainingClass();
if (containingClass != null) {
if (!JCiPUtil.isImmutable(containingClass)) {
return;
}
holder.registerProblem(field, "Non-final field #ref in @Immutable class #loc");
}
}
};
}
@Override
@Nonnull
public PsiElementVisitor buildVisitorImpl(
@Nonnull final ProblemsHolder holder,
boolean isOnTheFly,
LocalInspectionToolSession session,
Object state
) {
return new JavaElementVisitor() {
@Override
public void visitField(PsiField field) {
super.visitField(field);
if (field.hasModifierProperty(PsiModifier.FINAL)) {
return;
}
final PsiClass containingClass = field.getContainingClass();
if (containingClass != null) {
if (!JCiPUtil.isImmutable(containingClass)) {
return;
}
holder.registerProblem(field, "Non-final field #ref in @Immutable class #loc");
}
}
};
}
}
163 changes: 81 additions & 82 deletions ...com/intellij/java/impl/codeInspection/concurrencyAnnotations/NonFinalGuardInspection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,100 +25,99 @@
import consulo.language.editor.inspection.localize.InspectionLocalize;
import consulo.language.psi.PsiElementVisitor;
import consulo.language.psi.util.PsiTreeUtil;
import org.jetbrains.annotations.Nls;

import consulo.localize.LocalizeValue;
import jakarta.annotation.Nonnull;

@ExtensionImpl
public class NonFinalGuardInspection extends BaseJavaLocalInspectionTool {
@Nonnull
@Override
public LocalizeValue getGroupDisplayName() {
return InspectionLocalize.groupNamesConcurrencyAnnotationIssues();
}

@Override
@Nonnull
public String getGroupDisplayName() {
return InspectionLocalize.groupNamesConcurrencyAnnotationIssues().get();
}

@Override
@Nls
@Nonnull
public String getDisplayName() {
return "Non-final @GuardedBy field";
}
@Nonnull
@Override
public LocalizeValue getDisplayName() {
return LocalizeValue.localizeTODO("Non-final @GuardedBy field");
}

@Override
@Nonnull
public String getShortName() {
return "NonFinalGuard";
}
@Override
@Nonnull
public String getShortName() {
return "NonFinalGuard";
}


@Override
@Nonnull
public PsiElementVisitor buildVisitorImpl(@Nonnull ProblemsHolder holder,
boolean isOnTheFly,
LocalInspectionToolSession session,
Object state) {
return new Visitor(holder);
}
@Override
@Nonnull
public PsiElementVisitor buildVisitorImpl(
@Nonnull ProblemsHolder holder,
boolean isOnTheFly,
LocalInspectionToolSession session,
Object state
) {
return new Visitor(holder);
}

private static class Visitor extends JavaElementVisitor {
private final ProblemsHolder myHolder;
private static class Visitor extends JavaElementVisitor {
private final ProblemsHolder myHolder;

public Visitor(ProblemsHolder holder) {
public Visitor(ProblemsHolder holder) {

myHolder = holder;
}
myHolder = holder;
}

@Override
public void visitAnnotation(PsiAnnotation annotation) {
super.visitAnnotation(annotation);
if (!JCiPUtil.isGuardedByAnnotation(annotation)) {
return;
}
final String guardValue = JCiPUtil.getGuardValue(annotation);
if (guardValue == null || "this".equals(guardValue)) {
return;
}
final PsiClass containingClass = PsiTreeUtil.getParentOfType(annotation, PsiClass.class);
if (containingClass == null) {
return;
}
final PsiField guardField = containingClass.findFieldByName(guardValue, true);
if (guardField == null) {
return;
}
if (guardField.hasModifierProperty(PsiModifier.FINAL)) {
return;
}
final PsiAnnotationMemberValue member = annotation.findAttributeValue("value");
if (member == null) {
return;
}
myHolder.registerProblem(member, "Non-final @GuardedBy field #ref #loc");
}
@Override
public void visitAnnotation(PsiAnnotation annotation) {
super.visitAnnotation(annotation);
if (!JCiPUtil.isGuardedByAnnotation(annotation)) {
return;
}
final String guardValue = JCiPUtil.getGuardValue(annotation);
if (guardValue == null || "this".equals(guardValue)) {
return;
}
final PsiClass containingClass = PsiTreeUtil.getParentOfType(annotation, PsiClass.class);
if (containingClass == null) {
return;
}
final PsiField guardField = containingClass.findFieldByName(guardValue, true);
if (guardField == null) {
return;
}
if (guardField.hasModifierProperty(PsiModifier.FINAL)) {
return;
}
final PsiAnnotationMemberValue member = annotation.findAttributeValue("value");
if (member == null) {
return;
}
myHolder.registerProblem(member, "Non-final @GuardedBy field #ref #loc");
}

@Override
public void visitDocTag(PsiDocTag psiDocTag) {
super.visitDocTag(psiDocTag);
if (!JCiPUtil.isGuardedByTag(psiDocTag)) {
return;
}
final String guardValue = JCiPUtil.getGuardValue(psiDocTag);
if ("this".equals(guardValue)) {
return;
}
final PsiClass containingClass = PsiTreeUtil.getParentOfType(psiDocTag, PsiClass.class);
if (containingClass == null) {
return;
}
final PsiField guardField = containingClass.findFieldByName(guardValue, true);
if (guardField == null) {
return;
}
if (guardField.hasModifierProperty(PsiModifier.FINAL)) {
return;
}
myHolder.registerProblem(psiDocTag, "Non-final @GuardedBy field \"" + guardValue + "\" #loc");
@Override
public void visitDocTag(PsiDocTag psiDocTag) {
super.visitDocTag(psiDocTag);
if (!JCiPUtil.isGuardedByTag(psiDocTag)) {
return;
}
final String guardValue = JCiPUtil.getGuardValue(psiDocTag);
if ("this".equals(guardValue)) {
return;
}
final PsiClass containingClass = PsiTreeUtil.getParentOfType(psiDocTag, PsiClass.class);
if (containingClass == null) {
return;
}
final PsiField guardField = containingClass.findFieldByName(guardValue, true);
if (guardField == null) {
return;
}
if (guardField.hasModifierProperty(PsiModifier.FINAL)) {
return;
}
myHolder.registerProblem(psiDocTag, "Non-final @GuardedBy field \"" + guardValue + "\" #loc");
}
}
}
}
Loading
Loading