Extend layer limit from 255 to 65535 by using 16-bit tag field#385
Draft
xinyangge wants to merge 1 commit intocontainerd:mainfrom
Draft
Extend layer limit from 255 to 65535 by using 16-bit tag field#385xinyangge wants to merge 1 commit intocontainerd:mainfrom
xinyangge wants to merge 1 commit intocontainerd:mainfrom
Conversation
The SegmentMapping struct's tag field was 8-bit, limiting overlaybd to 255 stacked layers. This change extends the tag to 16-bit by borrowing 8 bits from moffset (55->47 bits), which still allows 64 PB per layer file - far exceeding practical needs. Changes: - index.h: Change tag from uint8_t to uint16_t, moffset from 55 to 47 bits - file.h: Update MAX_STACK_LAYERS from 255 to 65535 - file.cpp: Update m_rw_tag, min_tag, warp_file_tag types to uint16_t - index.cpp: Update ro_index_count parameter and merge limit to 65535 - config.h: Update MAX_LAYER_CNT from 256 to 65536 Note: This is a breaking change - layers created with this version are not compatible with older overlaybd versions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
Hello~ actually LSMTFile supports unlimited layer size via overlaybd/src/overlaybd/lsmt/file.cpp Line 1635 in 222aa97 You can use open_files_ro() to open multiple layers as a single IFile*. Use this IFile as another ReadOnly layer, like Russian nesting doll :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SegmentMapping struct's tag field was 8-bit, limiting overlaybd to 255 stacked layers. This change extends the tag to 16-bit by borrowing 8 bits from moffset (55->47 bits), which still allows 64 PB per layer file - far exceeding practical needs.
Changes:
Note: This is a breaking change - layers created with this version are not compatible with older overlaybd versions.
🤖 Generated with Claude Code
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: