Implement create_snapshot interface for ImageFile#392
Merged
BigVan merged 1 commit intocontainerd:dev/snapshotfrom Feb 2, 2026
Merged
Implement create_snapshot interface for ImageFile#392BigVan merged 1 commit intocontainerd:dev/snapshotfrom
BigVan merged 1 commit intocontainerd:dev/snapshotfrom
Conversation
BigVan
reviewed
Jan 28, 2026
src/image_file.cpp
Outdated
|
|
||
| auto upper = new_cfg.upper(); | ||
| auto lowers = new_cfg.lowers(); | ||
| if(lowers[lowers.size()-1].file() != conf.upper().data()) |
Member
There was a problem hiding this comment.
It is unnecessary to keep the same filename, we can seal the upper data file and rename it.
src/image_file.h
Outdated
| ssize_t pread(void *buf, size_t count, off_t offset) override | ||
| { | ||
| return m_file->pread(buf, count, offset); | ||
| } |
Member
There was a problem hiding this comment.
I think all I/O requests can be automatically transferred to pread/pwrite via VirtualFile?
| } | ||
| delete m_backing_index; | ||
| if(m_ownership) // !!! | ||
| delete m_backing_index; |
Signed-off-by: Xun Chen <xunchen@hust.edu.cn>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements the create_snapshot interface for ImageFile.
The snapshot is created by restacking the current RW layer via m_file->restack(), turning the existing upper layer into a new lower layer and switching to a new upper layer defined in the updated image config.
We also add several helper interfaces in IFileRO and IComboIndex to keep m_lower_file and m_upper_file synchronized. This ensures proper resource cleanup and avoids memory leakage during snapshot creation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: