set base-image annotations#3423
Merged
openshift-ci[bot] merged 1 commit intocontainers:mainfrom Aug 3, 2021
Merged
Conversation
imjasonh
approved these changes
Aug 3, 2021
imjasonh
left a comment
imjasonh
left a comment
There was a problem hiding this comment.
Woohoo! Thanks for implementing this so quickly!
| run_buildah images -a | ||
| expect_line_count 4 | ||
|
|
||
| # Note that the base-image annotations are empty here since a Container with |
Since opencontainers/image-spec/pull/822/ the OCI spec supports two new annotations to set the fully-qualified name and the digest of the base image. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Member
Author
|
Had to massage some other integration tests which barked with the new annotations. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imjasonh, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Member
|
LGTM |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since opencontainers/image-spec/pull/822/ the OCI spec supports two new
annotations to set the fully-qualified name and the digest of the base
image.
Signed-off-by: Valentin Rothberg rothberg@redhat.com
@rhatdan @nalind @TomSweeneyRedHat @imjasonh PTAL