vendor containers/image to 386d6c33c9d622ed84baf14f4b1ff1be86800ccd#393
Closed
boaz0 wants to merge 1 commit intocontainers:masterfrom
boaz0:vendor_containers_image
Closed
vendor containers/image to 386d6c33c9d622ed84baf14f4b1ff1be86800ccd#393boaz0 wants to merge 1 commit intocontainers:masterfrom boaz0:vendor_containers_image
boaz0 wants to merge 1 commit intocontainers:masterfrom
boaz0:vendor_containers_image
Conversation
Signed-off-by: Boaz Shuster <bshuster@redhat.com>
Collaborator
|
Can one of the admins verify this patch?
|
Member
|
bot, add author to whitelist |
Member
|
LGTM |
Member
Member
Collaborator
|
📌 Commit 7c66765 has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - status-papr |
Member
nalind
pushed a commit
that referenced
this pull request
Apr 2, 2018
When creating container storage by name, if that name is a tagged image then the storage could not be found. We now use the image id which seems more reliable. Also added an integration test to protect against regression. Signed-off-by: baude <bbaude@redhat.com> Closes: #393 Approved by: mheon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #385 and containers/image#390.