Fix top-level source example in godoc#217
Merged
runcom merged 1 commit intocontainers:masterfrom Feb 7, 2017
Merged
Conversation
Collaborator
|
👍 pending tests. Thanks! |
Contributor
Author
|
This should be ready soon. |
Member
|
lgtm |
Member
|
@erikh could you rebase and I'll merge? |
Contributor
Author
|
done |
Member
|
seems like opencontainers/image-spec#411 broke tests here in containers/image (potential fix here #223) |
giuseppe
pushed a commit
to giuseppe/image
that referenced
this pull request
Jan 24, 2017
Bump to 0.1.15 and then again to 0.1.16-dev
Collaborator
|
@erikh Could you rebase again, to trigger a test run, please? |
* gofmt source * fix syntax in image name Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Contributor
Author
|
done! sorry to make ya'll wait. |
Collaborator
|
That wasn’t your fault, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This won't pass just yet.
I gofmt'd the source too, but the
//syntax requirement that exists now wasthrowing off the original example which would just panic.