Skip to content

ci: add coverage integration using Codecov tool#61

Merged
djach7 merged 1 commit intocontainers:mainfrom
rmiki-dev:code-cov
Mar 26, 2026
Merged

ci: add coverage integration using Codecov tool#61
djach7 merged 1 commit intocontainers:mainfrom
rmiki-dev:code-cov

Conversation

@rmiki-dev
Copy link
Collaborator

@rmiki-dev rmiki-dev commented Mar 19, 2026

  • Integrate with codecov.io for coverage reporting

  • Renamed coverage output file to integration.out and unit.out for clarity

  • Generate and upload coverage reports in CI on pull requests

  • Add coverage badge to README.md

Closes #27

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces code coverage reporting using Codecov, improving the project's testing infrastructure and providing a clear view of test coverage. It also updates the README to include a coverage badge.

Highlights

  • Code Coverage Integration: This PR integrates Codecov for coverage reporting, enhancing the project's CI process.
  • File Renaming: The coverage output file was renamed to coverage.out for better clarity.
  • README Update: A coverage badge was added to README.md to display the project's coverage status.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates Codecov for coverage reporting by updating the Makefile and adding a coverage badge to the README. While the Makefile changes are good, the README update introduces a critical security vulnerability by exposing a Codecov token in a public file. This token must be removed from the badge URL to prevent potential misuse.

@rmiki-dev rmiki-dev force-pushed the code-cov branch 3 times, most recently from e5c268b to e14d0cd Compare March 19, 2026 18:11
@codecov
Copy link

codecov bot commented Mar 19, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@rmiki-dev rmiki-dev marked this pull request as ready for review March 19, 2026 18:26
@rmiki-dev rmiki-dev requested a review from runcom March 19, 2026 18:28
Copy link

@knecasov knecasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments.

Is uploading coverage data to Codecov SaaS (codecov.io) acceptable for this project, please?

I would recommend moving 'Closes #27' from the PR title to the PR description body.

@rmiki-dev rmiki-dev changed the title ci: add coverage integration using Codecov tool Closes #27 ci: add coverage integration using Codecov tool Mar 23, 2026
@rmiki-dev
Copy link
Collaborator Author

I added a few comments.

Is uploading coverage data to Codecov SaaS (codecov.io) acceptable for this project, please?

I would recommend moving 'Closes #27' from the PR title to the PR description body.

Yes, codecov.io or any other simlar service is acceptable. I have addressed all comments, thank you!

Copy link
Collaborator

@kgiusti kgiusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intent to get coverage for both unit-test and integration-test?

Copy link

@knecasov knecasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @kgiusti that results of integration tests are not considered now. Ken is already requesting changes so I am approving the PR - I do not have any other comments.

Note: I am not able to resolve conversations so feel free to close them if you are able to do so.

Copy link

@knecasov knecasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one comment. I do not want to block the merge, so I am approving the PR and will leave it up to you whether you would like to follow the recommendation.

Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
Copy link
Collaborator

@djach7 djach7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djach7 djach7 merged commit a5b601f into containers:main Mar 26, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add code coverage integration

4 participants