ci: add coverage integration using Codecov tool#61
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces code coverage reporting using Codecov, improving the project's testing infrastructure and providing a clear view of test coverage. It also updates the README to include a coverage badge. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request integrates Codecov for coverage reporting by updating the Makefile and adding a coverage badge to the README. While the Makefile changes are good, the README update introduces a critical security vulnerability by exposing a Codecov token in a public file. This token must be removed from the badge URL to prevent potential misuse.
e5c268b to
e14d0cd
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Yes, codecov.io or any other simlar service is acceptable. I have addressed all comments, thank you! |
kgiusti
left a comment
There was a problem hiding this comment.
Is the intent to get coverage for both unit-test and integration-test?
There was a problem hiding this comment.
I agree with @kgiusti that results of integration tests are not considered now. Ken is already requesting changes so I am approving the PR - I do not have any other comments.
Note: I am not able to resolve conversations so feel free to close them if you are able to do so.
knecasov
left a comment
There was a problem hiding this comment.
I added one comment. I do not want to block the merge, so I am approving the PR and will leave it up to you whether you would like to follow the recommendation.
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
Integrate with codecov.io for coverage reporting
Renamed coverage output file to
integration.outandunit.outfor clarityGenerate and upload coverage reports in CI on pull requests
Add coverage badge to README.md
Closes #27