fix: replacing select with multiselect for content type picker modal [INTEG-3378] #10380
+76
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removing `SelectedContentTypes` type
| @@ -1,9 +1,9 @@ | |||
| import { useState, useCallback } from 'react'; | |||
| import { SelectedContentType } from '../locations/Page/components/modals/step_2/SelectContentTypeModal'; | |||
| import { ContentTypeProps } from 'contentful-management'; | |||
harikakondur
changed the title
apps/google-docs/src/locations/Page/components/modals/step_2/SelectContentTypeModal.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
142
to
148
| isLoading | ||
| ? 'Loading content types...' | ||
| : contentTypes.length === 0 | ||
| ? 'No content types in space' | ||
| : selectedContentTypes.length === 0 | ||
| ? 'Select one or more' | ||
| : `${selectedContentTypes.length} selected` |
Contributor
There was a problem hiding this comment.
nested turnaries are hard for me to read to be honest
Contributor
Author
There was a problem hiding this comment.
added a helper function getPlaceHoldertext()
const getPlaceholderText = () => {
if (isLoading) return 'Loading content types...';
if (contentTypes.length === 0) return 'No content types in space';
if (selectedContentTypes.length === 0) return 'Select one or more';
return `${selectedContentTypes.length} selected`;
};
david-shibley-contentful
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectedContentTypestype, usingContentTypePropscma type insteadhttps://contentful.atlassian.net/browse/INTEG-3378
Screen.Recording.2025-12-30.at.9.39.37.PM.mov