Convert library to AMD and CommonJS module. Updated the LuminateExtend library to respond to ajax errors. Updated version number text to 1.8.1. Added package.json and bower.json file for publishing#79
Open
rxnlabs wants to merge 5 commits intoconvio:masterfrom
Conversation
…d library to respond to ajax errors. Updated version number text to 1.8.1. Added package.json and bower.json file for publishing When making a request to the Luminate API and an HTTP error occurs (e.g. cross-site domain requests), neither the success callback nor the error callback are called. This causes confusion since you would have no idea why your Ajax request failed since your handler would not be called. Updated README with NPM installation method
…ions to main README
…uth() method when no callback is passed If no callback is passed to the luminateExtend.api.getAuth() method, the auth token and auth type should just be returned. This is useful in cases where we're just looking to return the cached authorization token and we don't need to wait on an ajax call to do that
…returns the authorization type and the token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for LuminateExtend to handle ajax errors when making a request to the Luminate API.
When making a request to the Luminate API causes a HTTP error (e.g. cross-site domain requests), neither the success callback nor the error callback would be called. This causes confusion since you would have no idea why your Ajax request failed since your handler would not be called.
Updated README with NPM installation method