Add passkey browser auth to CLI#3804
Open
ntner wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CLI's session authentication previously completed the WebAuthn step only by talking to a physical USB security key over HID. Users who authenticate with a passkey (a platform authenticator such as Touch ID or Windows Hello, or a synced passkey) have no such device for the CLI to drive, so every command failed with:
This adds a browser-based path: when the console issues a session token challenge, the CLI opens the browser to the console's existing
/login/u2fpage, the browser performs the WebAuthn ceremony (which supports passkeys, platform authenticators, and security keys), and the resulting assertion is returned to the CLI over a short-lived local callback. The direct hardware-key path is retained behind an environment toggle.Configuration
CONVOX_WEB_U2F_DISABLEtrue/ unsettrue, skip the browser flow and authenticate directly against a physical USB security key over HID (the previous behavior).