Fix multi-page JIT module invalidation#1585
Open
blixt wants to merge 2 commits into
Open
Conversation
blixt
commented
Jun 10, 2026
| }) => set_tlb_code(virt_page, *wasm_table_index, entry_points, *state_flags), | ||
| None => cpu::clear_tlb_code(phys_page.to_u32() as i32), | ||
| // Note: tlb_code is indexed by virtual page | ||
| None => cpu::clear_tlb_code(virt_page.to_u32() as i32), |
Author
There was a problem hiding this comment.
Drive-by fix: this seems like it should use virt_page, not phys_page
Owner
|
I recently started looking in this independently, and intend to propose a different fix for this. The drive-by fix looks good, feel free to only fix that and remove the other commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Windows 98 I would get occasional blue screens, but only when JIT was enabled. I tracked it down (disclosure: with the help of Claude Fable 5, but this PR has been tested and written by me) to cases where a JIT module was spread across more than one page.
This PR fixes the issue by tracking all pages and cleaning up appropriately.
There's also a drive-by fix for a line that probably should have been targeting the virtual page slot, not the physical slot, but happy to remove that if it's wrong.