Waterbody bug fix#1077
Open
kapildadheech wants to merge 4 commits into
Open
Conversation
amanodt
reviewed
Jul 8, 2026
amanodt
reviewed
Jul 8, 2026
amanodt
reviewed
Jul 8, 2026
amanodt
reviewed
Jul 8, 2026
| asset_suffix=None, | ||
| asset_folder_list=None, | ||
| start_date="2017-07-01", | ||
| end_date="2025-06-30", |
Member
There was a problem hiding this comment.
We should avoid such hard-coding as they are relevant for one year only and we will have to make changes next year again. We should rather restrict the flow if correct parameters are not provided.
Reject API and water-rej compute flows when the analysis window is missing so date ranges stay caller-provided year to year. Co-authored-by: Cursor <cursoragent@cursor.com>
…est-water paths. Co-authored-by: Cursor <cursoragent@cursor.com>
kapildadheech
force-pushed
the
features/waterbody_fix
branch
from
July 13, 2026 09:17
26df129 to
71648ff
Compare
Member
|
Conflict in branch. Please fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@amanodt Please review and merge. Changes are already in production due to some urgency