feat: add new formatter log output for github#59
Merged
Conversation
c343cf2 to
f2418cf
Compare
fzipi
commented
Feb 29, 2024
9eaefbd to
9ea579c
Compare
Member
Author
8891875 to
932d12b
Compare
Member
Author
|
@theseion Looks like test is failing (cmd/regex_compare_test.go:151) because the error was not triggered per |
932d12b to
58bbb52
Compare
fzipi
commented
Mar 2, 2024
fzipi
commented
Mar 2, 2024
theseion
requested changes
Mar 3, 2024
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
eda978b to
7422dfa
Compare
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
7422dfa to
43331f6
Compare
theseion
requested changes
Aug 15, 2025
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Contributor
|
@fzipi I've unresolved three comments, as the suggestions were not applied when I think they should have been. |
Member
Author
|
@copilot Can you address theseion's open comments? |
…ale comments Agent-Logs-Url: https://github.com/coreruleset/crs-toolchain/sessions/1505ba03-1173-4575-bc23-2783510abecc Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
Contributor
Done in commit 998987e:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/coreruleset/crs-toolchain/sessions/1505ba03-1173-4575-bc23-2783510abecc Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
theseion
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Felipe Zipitria felipe.zipitria@owasp.org
Modify logger to output in a format parseable by Github's runners.
Fixes #56.
Pending: