Add # of tracked request metric in query scheduler#7355
Open
SungJin1212 wants to merge 2 commits intocortexproject:masterfrom
Open
Add # of tracked request metric in query scheduler#7355SungJin1212 wants to merge 2 commits intocortexproject:masterfrom
SungJin1212 wants to merge 2 commits intocortexproject:masterfrom
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
dosubot
bot
added
the
type/observability
SungJin1212
changed the title
friedrichg
reviewed
Mar 16, 2026
pkg/scheduler/scheduler.go
Outdated
| }, s.getConnectedFrontendClientsMetric) | ||
|
|
||
| s.pendingRequestsCurrent = promauto.With(registerer).NewGaugeFunc(prometheus.GaugeOpts{ | ||
| Name: "cortex_query_scheduler_pending_requests", |
Member
There was a problem hiding this comment.
Suggested change
| Name: "cortex_query_scheduler_pending_requests", | |
| Name: "cortex_query_scheduler_tracked_requests", |
I believe this metric tracks pending and queries inflight. Pending gives the connotation that is not running yet.
Maybe renaming the map is also due
Member
Author
There was a problem hiding this comment.
Yeah, it looks nice. I updated the PR with renaming.
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a query scheduler metric
cortex_query_scheduler_pending_requeststo track the current number of requests held by the scheduler.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]