Skip to content

Fix flaky TestLoader_ShouldCacheIndexNotFoundOnBackgroundUpdates #7358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SungJin1212 merged 1 commit into from
Mar 18, 2026
Merged

Fix flaky TestLoader_ShouldCacheIndexNotFoundOnBackgroundUpdates #7358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pkg/storage/tsdb/bucketindex/loader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,14 +475,17 @@ func TestLoader_ShouldCacheIndexNotFoundOnBackgroundUpdates(t *testing.T) {
return testutil.ToFloat64(loader.loadAttempts) > prevLoads
})

// Wait until the index is offloaded (metrics becomes 0).
// We expect the bucket index is not considered loaded because of the error.
assert.NoError(t, testutil.GatherAndCompare(reg, bytes.NewBufferString(`
test.Poll(t, 3*time.Second, true, func() any {
err := testutil.GatherAndCompare(reg, bytes.NewBufferString(`
# HELP cortex_bucket_index_loaded Number of bucket indexes currently loaded in-memory.
# TYPE cortex_bucket_index_loaded gauge
cortex_bucket_index_loaded 0
`),
"cortex_bucket_index_loaded",
))
`), "cortex_bucket_index_loaded")

return err == nil
})

// Try to get the index again. We expect no load attempt because the error has been cached.
prevLoads = testutil.ToFloat64(loader.loadAttempts)
Expand Down
Loading